From 4a29c3d87019f40367e7ed209187ae1aa1dfef50 Mon Sep 17 00:00:00 2001
From: Wiscaksono <wwicaksono96@gmail.com>
Date: Fri, 15 May 2026 17:09:49 +0700
Subject: [PATCH 1/2] types(oracledb): add NCLOB to fetchAsString type

NCLOB is supported at runtime in oracledb v6+ (see lib/settings.js)
but was missing from the @types/oracledb fetchAsString type definition.

Runtime source confirms NCLOB handling in createFetchTypeMap:
  case types.DB_TYPE_CLOB:
  case types.DB_TYPE_NCLOB:
    map.set(types.DB_TYPE_CLOB, types.DB_TYPE_LONG);
    map.set(types.DB_TYPE_NCLOB, types.DB_TYPE_LONG_NVARCHAR);
---
 types/oracledb/index.d.ts        | 2 +-
 types/oracledb/oracledb-tests.ts | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/types/oracledb/index.d.ts b/types/oracledb/index.d.ts
index c2fa4cb95a70e9..9f822dc477ad5c 100644
--- a/types/oracledb/index.d.ts
+++ b/types/oracledb/index.d.ts
@@ -658,7 +658,7 @@ declare namespace OracleDB {
      *
      * For non-CLOB types, the conversion to string is handled by Oracle client libraries and is often referred to as defining the fetch type.
      */
-    let fetchAsString: Array<typeof DATE | typeof NUMBER | typeof BUFFER | typeof CLOB>;
+     let fetchAsString: Array<typeof DATE | typeof NUMBER | typeof BUFFER | typeof CLOB | typeof NCLOB>;
     /**
      * Converter can be used with fetch type handlers to change the returned data.
      * If the value returned by the fetch type handler function is undefined then no conversion takes place.
diff --git a/types/oracledb/oracledb-tests.ts b/types/oracledb/oracledb-tests.ts
index a84d75544dd064..60dc9f3622c464 100644
--- a/types/oracledb/oracledb-tests.ts
+++ b/types/oracledb/oracledb-tests.ts
@@ -720,7 +720,7 @@ export const fetchAsBufferTests = (): void => {
 };
 
 export const fetchAsStringTests = (): void => {
-    defaultOracledb.fetchAsString = [oracledb.DATE, oracledb.NUMBER, oracledb.BUFFER, oracledb.CLOB];
+    defaultOracledb.fetchAsString = [oracledb.DATE, oracledb.NUMBER, oracledb.BUFFER, oracledb.CLOB, oracledb.NCLOB];
     // @ts-expect-error
     defaultOracledb.fetchAsString = [{}];
     // @ts-expect-error

From 28ce530a65c276c88b31dc8b69ef88ce26cc1432 Mon Sep 17 00:00:00 2001
From: Wiscaksono <wwicaksono96@gmail.com>
Date: Fri, 15 May 2026 19:47:13 +0700
Subject: [PATCH 2/2] chore(oracledb): format types with dprint

---
 types/oracledb/index.d.ts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/types/oracledb/index.d.ts b/types/oracledb/index.d.ts
index 9f822dc477ad5c..7c31d1acc55ffa 100644
--- a/types/oracledb/index.d.ts
+++ b/types/oracledb/index.d.ts
@@ -658,7 +658,7 @@ declare namespace OracleDB {
      *
      * For non-CLOB types, the conversion to string is handled by Oracle client libraries and is often referred to as defining the fetch type.
      */
-     let fetchAsString: Array<typeof DATE | typeof NUMBER | typeof BUFFER | typeof CLOB | typeof NCLOB>;
+    let fetchAsString: Array<typeof DATE | typeof NUMBER | typeof BUFFER | typeof CLOB | typeof NCLOB>;
     /**
      * Converter can be used with fetch type handlers to change the returned data.
      * If the value returned by the fetch type handler function is undefined then no conversion takes place.