🤖 Merge PR #55724 [node] Fix property 'detail' of PerformanceEntry by @cafca

cafca · web-flow · commit beceb9d58e7e · 2021-09-19T01:36:27.000-07:00
* Fix property 'detail' of PerformanceEntry This spelling mistake in a property name has been fixed in node.js per nodejs/node#40019 * Add missing comma * Fix 'detail' property name in perf_hooks test
diff --git a/types/node/perf_hooks.d.ts b/types/node/perf_hooks.d.ts
@@ -84,7 +84,7 @@ declare module 'perf_hooks' {
          * Additional detail specific to the `entryType`.
          * @since v16.0.0
          */
-        readonly details?: NodeGCPerformanceDetail | unknown | undefined; // TODO: Narrow this based on entry type.
+        readonly detail?: NodeGCPerformanceDetail | unknown | undefined; // TODO: Narrow this based on entry type.
     }
     /**
      * _This property is an extension by Node.js. It is not available in Web browsers._
diff --git a/types/node/test/perf_hooks.ts b/types/node/test/perf_hooks.ts
@@ -48,9 +48,9 @@ const performanceObserverCallback: PerformanceObserverCallback = (list, obs) =>
     const name: string = entries[0].name;
     const startTime: number = entries[0].startTime;
     const entryTypes: EntryType = entries[0].entryType;
-    const details: NodeGCPerformanceDetail = entries[0].details as NodeGCPerformanceDetail;
-    const kind: number | undefined = details.kind;
-    const flags: number | undefined = details.flags;
+    const detail: NodeGCPerformanceDetail = entries[0].detail as NodeGCPerformanceDetail;
+    const kind: number | undefined = detail.kind;
+    const flags: number | undefined = detail.flags;
 
     if (kind === constants.NODE_PERFORMANCE_GC_MAJOR) {
         if (flags === constants.NODE_PERFORMANCE_GC_FLAGS_ALL_EXTERNAL_MEMORY) {
@@ -64,7 +64,7 @@ obs.observe({
     entryTypes: ['gc'],
 });
 obs.observe({
-    type: 'gc'
+    type: 'gc',
 });
 
 const monitor: IntervalHistogram = monitorEventLoopDelay({

Original file line number	Diff line number	Diff line change
`@@ -84,7 +84,7 @@ declare module 'perf_hooks' {`
`84`	`84`	* Additional detail specific to the `entryType`.
`85`	`85`	`* @since v16.0.0`
`86`	`86`	`*/`
`87`		`- readonly details?: NodeGCPerformanceDetail \| unknown \| undefined; // TODO: Narrow this based on entry type.`
	`87`	`+ readonly detail?: NodeGCPerformanceDetail \| unknown \| undefined; // TODO: Narrow this based on entry type.`
`88`	`88`	`}`
`89`	`89`	`/**`
`90`	`90`	`* _This property is an extension by Node.js. It is not available in Web browsers._`