fix WandbLoggerConfig include additional kwargs in pydantic schema - #3469
Draft
deruyter92 wants to merge 1 commit into
Draft
fix WandbLoggerConfig include additional kwargs in pydantic schema#3469deruyter92 wants to merge 1 commit into
deruyter92 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Weights and Biases logger accepts a variety of extra arguments, such as
notes,tags, etc. These were mediated throughwandb_kwargswhich could be defined at top-level. However since the introduction of the stricter pydantic schemas these top-level arguments withextra="forbid"would raise aValidationError.This PR:
wandb_kwargsfield in theWandBloggerConfig(was never passed correctly to the logger)notes,tags,groupto the top-level config.