Fix outdated str function call to correct Path suffix swap for CSV to h5 conversion - #3465
Draft
C-Achard wants to merge 1 commit into
Draft
Fix outdated str function call to correct Path suffix swap for CSV to h5 conversion#3465C-Achard wants to merge 1 commit into
C-Achard wants to merge 1 commit into
Conversation
… H5 conversion
Update `convertcsv2h5` to build the HDF5 output path with `Path.with_suffix(".h5")` instead of string replacement. This makes filename handling safer and consistent with `Path` objects, avoiding edge cases with `.replace()` on path strings.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates convertcsv2h5 to construct the HDF5 output filename using pathlib.Path.with_suffix(".h5") rather than calling .replace() on the CSV path, aligning output path handling with Path-based code and avoiding incorrect .replace() behavior on Path objects.
Changes:
- Build the
.h5output path viafn.with_suffix(".h5"). - Pass the resulting
Pathdirectly topandas.DataFrame.to_hdf(...)for writing.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update
convertcsv2h5to build the HDF5 output path withPath.with_suffix(".h5")instead of string replacement. This makes filename handling safer and consistent withPathobjects, avoiding edge cases with.replace()on path strings.