Skip to content

Commit c2389da

Browse files
authored
ci: Use the default redis port for tests and remove unnecessary action (feast-dev#2398)
Signed-off-by: Achal Shah <achals@gmail.com>
1 parent 6498794 commit c2389da

3 files changed

Lines changed: 1 addition & 9 deletions

File tree

.github/workflows/master_only.yml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -126,10 +126,6 @@ jobs:
126126
run: pip install pip-tools
127127
- name: Install dependencies
128128
run: make install-python-ci-dependencies
129-
- name: Start Redis
130-
uses: supercharge/redis-github-action@1.4.0
131-
with:
132-
redis-port: 12345
133129
- name: Setup Redis Cluster
134130
run: |
135131
docker pull vishnunair/docker-redis-cluster:latest

.github/workflows/pr_integration_tests.yml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -154,10 +154,6 @@ jobs:
154154
run: |
155155
make compile-protos-go
156156
make install-python-ci-dependencies
157-
- name: Start Redis
158-
uses: supercharge/redis-github-action@1.4.0
159-
with:
160-
redis-port: 12345
161157
- name: Setup Redis Cluster
162158
run: |
163159
docker pull vishnunair/docker-redis-cluster:latest

sdk/python/tests/integration/feature_repos/repo_configuration.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@
4848
DYNAMO_CONFIG = {"type": "dynamodb", "region": "us-west-2"}
4949
# Port 12345 will chosen as default for redis node configuration because Redis Cluster is started off of nodes
5050
# 6379 -> 6384. This causes conflicts in cli integration tests so we manually keep them separate.
51-
REDIS_CONFIG = {"type": "redis", "connection_string": "localhost:12345,db=0"}
51+
REDIS_CONFIG = {"type": "redis", "connection_string": "localhost:6379,db=0"}
5252
REDIS_CLUSTER_CONFIG = {
5353
"type": "redis",
5454
"redis_type": "redis_cluster",

0 commit comments

Comments
 (0)