Skip to content

Commit 3e2ebd1

Browse files
woopwoop
authored
Rename Metadata Store to Registry (feast-dev#1433)
* Rename metadata_store to registry Signed-off-by: Willem Pienaar <git@willem.co> * Rename metadata.db Signed-off-by: Willem Pienaar <git@willem.co>
1 parent f958f01 commit 3e2ebd1

12 files changed

+55
-55
lines changed

‎sdk/python/feast/feature_store.py‎

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -65,18 +65,18 @@ def __init__(
6565
self.config = load_repo_config(Path(repo_path))
6666
else:
6767
self.config = RepoConfig(
68-
metadata_store="./metadata.db",
68+
registry="./registry.db",
6969
project="default",
7070
provider="local",
7171
online_store=OnlineStoreConfig(
7272
local=LocalOnlineStoreConfig(path="online_store.db")
7373
),
7474
)
7575

76-
metadata_store_config = self.config.get_metadata_store_config()
76+
registry_config = self.config.get_registry_config()
7777
self._registry = Registry(
78-
registry_path=metadata_store_config.path,
79-
cache_ttl=timedelta(seconds=metadata_store_config.cache_ttl_seconds),
78+
registry_path=registry_config.path,
79+
cache_ttl=timedelta(seconds=registry_config.cache_ttl_seconds),
8080
)
8181

8282
@property
@@ -101,10 +101,10 @@ def refresh_registry(self):
101101
downloaded synchronously, which may increase latencies if the triggering method is get_online_features()
102102
"""
103103

104-
metadata_store_config = self.config.get_metadata_store_config()
104+
registry_config = self.config.get_registry_config()
105105
self._registry = Registry(
106-
registry_path=metadata_store_config.path,
107-
cache_ttl=timedelta(seconds=metadata_store_config.cache_ttl_seconds),
106+
registry_path=registry_config.path,
107+
cache_ttl=timedelta(seconds=registry_config.cache_ttl_seconds),
108108
)
109109
self._registry.refresh()
110110

‎sdk/python/feast/repo_config.py‎

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ class OnlineStoreConfig(FeastBaseModel):
3535
""" LocalOnlineStoreConfig: Optional local online store config """
3636

3737

38-
class MetadataStoreConfig(FeastBaseModel):
38+
class RegistryConfig(FeastBaseModel):
3939
""" Metadata Store Configuration. Configuration that relates to reading from and writing to the Feast registry."""
4040

4141
path: StrictStr
@@ -51,7 +51,7 @@ class MetadataStoreConfig(FeastBaseModel):
5151
class RepoConfig(FeastBaseModel):
5252
""" Repo config. Typically loaded from `feature_store.yaml` """
5353

54-
metadata_store: Union[StrictStr, MetadataStoreConfig]
54+
registry: Union[StrictStr, RegistryConfig]
5555
""" str: Path to metadata store. Can be a local path, or remote object storage path, e.g. gcs://foo/bar """
5656

5757
project: StrictStr
@@ -66,11 +66,11 @@ class RepoConfig(FeastBaseModel):
6666
online_store: Optional[OnlineStoreConfig] = None
6767
""" OnlineStoreConfig: Online store configuration (optional depending on provider) """
6868

69-
def get_metadata_store_config(self):
70-
if isinstance(self.metadata_store, str):
71-
return MetadataStoreConfig(path=self.metadata_store)
69+
def get_registry_config(self):
70+
if isinstance(self.registry, str):
71+
return RegistryConfig(path=self.registry)
7272
else:
73-
return self.metadata_store
73+
return self.registry
7474

7575

7676
# This is the JSON Schema for config validation. We use this to have nice detailed error messages
@@ -84,7 +84,7 @@ def get_metadata_store_config(self):
8484
"type": "object",
8585
"properties": {
8686
"project": {"type": "string"},
87-
"metadata_store": {"type": "string"},
87+
"registry": {"type": "string"},
8888
"provider": {"type": "string"},
8989
"online_store": {
9090
"type": "object",

‎sdk/python/feast/repo_operations.py‎

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -58,11 +58,11 @@ def parse_repo(repo_root: Path) -> ParsedRepo:
5858
def apply_total(repo_config: RepoConfig, repo_path: Path):
5959
os.chdir(repo_path)
6060
sys.path.append("")
61-
metadata_store_config = repo_config.get_metadata_store_config()
61+
registry_config = repo_config.get_registry_config()
6262
project = repo_config.project
6363
registry = Registry(
64-
registry_path=metadata_store_config.path,
65-
cache_ttl=timedelta(seconds=metadata_store_config.cache_ttl_seconds),
64+
registry_path=registry_config.path,
65+
cache_ttl=timedelta(seconds=registry_config.cache_ttl_seconds),
6666
)
6767
repo = parse_repo(repo_path)
6868

@@ -121,10 +121,10 @@ def apply_total(repo_config: RepoConfig, repo_path: Path):
121121

122122

123123
def teardown(repo_config: RepoConfig, repo_path: Path):
124-
metadata_store_config = repo_config.get_metadata_store_config()
124+
registry_config = repo_config.get_registry_config()
125125
registry = Registry(
126-
registry_path=metadata_store_config.path,
127-
cache_ttl=timedelta(seconds=metadata_store_config.cache_ttl_seconds),
126+
registry_path=registry_config.path,
127+
cache_ttl=timedelta(seconds=registry_config.cache_ttl_seconds),
128128
)
129129
project = repo_config.project
130130
registry_tables: List[Union[FeatureTable, FeatureView]] = []
@@ -136,11 +136,11 @@ def teardown(repo_config: RepoConfig, repo_path: Path):
136136

137137
def registry_dump(repo_config: RepoConfig):
138138
""" For debugging only: output contents of the metadata registry """
139-
metadata_store_config = repo_config.get_metadata_store_config()
139+
registry_config = repo_config.get_registry_config()
140140
project = repo_config.project
141141
registry = Registry(
142-
registry_path=metadata_store_config.path,
143-
cache_ttl=timedelta(seconds=metadata_store_config.cache_ttl_seconds),
142+
registry_path=registry_config.path,
143+
cache_ttl=timedelta(seconds=registry_config.cache_ttl_seconds),
144144
)
145145

146146
for entity in registry.list_entities(project=project):
@@ -173,7 +173,7 @@ def init_repo(repo_path: Path, minimal: bool):
173173
dedent(
174174
f"""
175175
project: {project_id}
176-
metadata_store: /path/to/metadata.db
176+
registry: /path/to/registry.db
177177
provider: local
178178
online_store:
179179
local:
@@ -182,7 +182,7 @@ def init_repo(repo_path: Path, minimal: bool):
182182
)
183183
)
184184
print(
185-
"Generated example feature_store.yaml. Please edit metadata_store and online_store"
185+
"Generated example feature_store.yaml. Please edit registry and online_store"
186186
"location before running apply"
187187
)
188188

@@ -211,7 +211,7 @@ def init_repo(repo_path: Path, minimal: bool):
211211
dedent(
212212
f"""
213213
project: {project_id}
214-
metadata_store: {"data/metadata.db"}
214+
registry: {"data/registry.db"}
215215
provider: local
216216
online_store:
217217
local:

‎sdk/python/tests/cli_utils.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ def local_repo(self, example_repo_py: str):
4646
dedent(
4747
f"""
4848
project: {project_id}
49-
metadata_store: {data_path / "metadata.db"}
49+
registry: {data_path / "registry.db"}
5050
provider: local
5151
online_store:
5252
local:

‎sdk/python/tests/online_write_benchmark.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ def benchmark_writes():
5050
with tempfile.TemporaryDirectory() as temp_dir:
5151
store = FeatureStore(
5252
config=RepoConfig(
53-
metadata_store=os.path.join(temp_dir, "metadata.db"),
53+
registry=os.path.join(temp_dir, "registry.db"),
5454
project=project_id,
5555
provider="gcp",
5656
)

‎sdk/python/tests/test_cli_gcp.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ def test_basic() -> None:
2828
dedent(
2929
f"""
3030
project: {project_id}
31-
metadata_store: {data_path / "metadata.db"}
31+
registry: {data_path / "registry.db"}
3232
provider: gcp
3333
"""
3434
)

‎sdk/python/tests/test_cli_local.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ def test_workflow() -> None:
2424
dedent(
2525
f"""
2626
project: foo
27-
metadata_store: {data_path / "metadata.db"}
27+
registry: {data_path / "registry.db"}
2828
provider: local
2929
online_store:
3030
local:

‎sdk/python/tests/test_feature_store.py‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ def feature_store_with_local_registry(self):
3636
fd, online_store_path = mkstemp()
3737
return FeatureStore(
3838
config=RepoConfig(
39-
metadata_store=registry_path,
39+
registry=registry_path,
4040
project="default",
4141
provider="local",
4242
online_store=OnlineStoreConfig(
@@ -57,11 +57,11 @@ def feature_store_with_gcs_registry(self):
5757
age=14
5858
) # delete buckets automatically after 14 days
5959
bucket.patch()
60-
bucket.blob("metadata.db")
60+
bucket.blob("registry.db")
6161

6262
return FeatureStore(
6363
config=RepoConfig(
64-
metadata_store=f"gs://{bucket_name}/metadata.db",
64+
registry=f"gs://{bucket_name}/registry.db",
6565
project="default",
6666
provider="gcp",
6767
)

‎sdk/python/tests/test_historical_retrieval.py‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -229,7 +229,7 @@ def test_historical_features_from_parquet_sources():
229229

230230
store = FeatureStore(
231231
config=RepoConfig(
232-
metadata_store=os.path.join(temp_dir, "metadata.db"),
232+
registry=os.path.join(temp_dir, "registry.db"),
233233
project="default",
234234
provider="local",
235235
online_store=OnlineStoreConfig(
@@ -331,7 +331,7 @@ def test_historical_features_from_bigquery_sources():
331331

332332
store = FeatureStore(
333333
config=RepoConfig(
334-
metadata_store=os.path.join(temp_dir, "metadata.db"),
334+
registry=os.path.join(temp_dir, "registry.db"),
335335
project="default",
336336
provider="local",
337337
online_store=OnlineStoreConfig(

‎sdk/python/tests/test_materialize_from_bigquery_to_datastore.py‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ def test_bigquery_table_to_datastore_correctness(self):
6565
),
6666
)
6767
config = RepoConfig(
68-
metadata_store="./metadata.db",
68+
registry="./registry.db",
6969
project=f"test_bq_table_correctness_{int(time.time())}",
7070
provider="gcp",
7171
)
@@ -133,7 +133,7 @@ def test_bigquery_query_to_datastore_correctness(self):
133133
),
134134
)
135135
config = RepoConfig(
136-
metadata_store="./metadata.db",
136+
registry="./registry.db",
137137
project=f"test_bq_query_correctness_{int(time.time())}",
138138
provider="gcp",
139139
)

0 commit comments

Comments
 (0)