Commit ddd6385

if (lib == nullptr || name == nullptr) {

return SOCKET_PATCH_NONE;

}

// Netty's native epoll transport ships its own .so outside the JDK's lib

// directory, so it is checked ahead of the in_jdk_directory gate below.

// Detection is by exported symbol rather than basename because the .so

// filename is relocated under shading (e.g. grpc-netty-shaded), while the

// JNI_OnLoad_/JNI_OnUnload_ suffix is not.

if (lib->findSymbol("JNI_OnLoad_netty_transport_native_epoll") != nullptr &&

lib->findSymbol("JNI_OnUnload_netty_transport_native_epoll") != nullptr) {

return SOCKET_PATCH_NETTY_NATIVE_EPOLL;

}

if (!in_jdk_directory) {

TEST(LibraryPatcherSocketStateTest, AdmitsNettyNativeEpollBySymbolOutsideJdkDirectory) {

CodeCache netty("libnetty_transport_native_epoll_x86_64.so");

CodeCache netty_shaded("libio_grpc_netty_shaded_netty_transport_native_epoll_x86_64.so");

CodeCache netty_partial("libnetty_transport_native_epoll_x86_64.so");

char marker_addresses[2] = {};

netty.add(&marker_addresses[0], 1, "JNI_OnLoad_netty_transport_native_epoll");

netty.add(&marker_addresses[1], 1, "JNI_OnUnload_netty_transport_native_epoll");

netty_shaded.add(&marker_addresses[0], 1, "JNI_OnLoad_netty_transport_native_epoll");

netty_shaded.add(&marker_addresses[1], 1, "JNI_OnUnload_netty_transport_native_epoll");

netty_partial.add(&marker_addresses[0], 1, "JNI_OnLoad_netty_transport_native_epoll");

// Admitted even though it is not located in the JDK's own lib directory,

// and regardless of the .so's basename (shading relocates the filename).

EXPECT_EQ(SOCKET_PATCH_NETTY_NATIVE_EPOLL,

LibraryPatcher::socket_patch_target_for_test(

&netty, "libnetty_transport_native_epoll_x86_64.so", false));

EXPECT_EQ(SOCKET_PATCH_NETTY_NATIVE_EPOLL,

LibraryPatcher::socket_patch_target_for_test(

&netty_shaded,

"libio_grpc_netty_shaded_netty_transport_native_epoll_x86_64.so",

false));

// Requires both symbols, mirroring the IBM JCL bridge's all-or-nothing check.

EXPECT_EQ(SOCKET_PATCH_NONE,

LibraryPatcher::socket_patch_target_for_test(

&netty_partial,

"libnetty_transport_native_epoll_x86_64.so", false));

}