Move advice crawl and helper resolution to separate resolver - #12191
Draft
sarahchen6 wants to merge 1 commit into
Draft
Move advice crawl and helper resolution to separate resolver#12191sarahchen6 wants to merge 1 commit into
sarahchen6 wants to merge 1 commit into
Conversation
|
🎯 Code Coverage (details) 🔗 Commit SHA: 1e102d2 | Docs | Datadog PR Page | Give us feedback! |
Contributor
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
sarahchen6
force-pushed
the
sarahchen6/separate-helper-plugin
branch
from
August 11, 2026 19:11
7b41b4d to
98fc668
Compare
sarahchen6
force-pushed
the
sarahchen6/separate-helper-plugin
branch
from
August 11, 2026 19:33
98fc668 to
1e102d2
Compare
sarahchen6
changed the base branch from
sarahchen6/use-array
to
sarahchen6/infer-helper-classes-pt-1
August 11, 2026 19:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
Extract advice crawl and helper resolution logic from
MuzzleGeneratortoHelperResolver. TheHelperResolveris called once per module. Then from this result,MuzzleGeneratorthen emits both the$Muzzlereference and module'shelperClassNames().Motivation
Put crawl-related logic in one place - this makes it easier to read and test.
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]