fix(openfeature): isolate malformed flag configuration - #12186
Draft
leoromanovsky wants to merge 2 commits into
Draft
fix(openfeature): isolate malformed flag configuration#12186leoromanovsky wants to merge 2 commits into
leoromanovsky wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
Isolates malformed OpenFeature flags so valid siblings remain usable while rejected keys return parse errors.
Changes:
- Tracks rejected flags per configuration refresh.
- Adds UFC validation, SemVer operators, and corrected assignment reasons.
- Expands canonical, malformed-input, refresh, and SemVer tests.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
feature-flagging-api/build.gradle.kts |
Adds parser test dependency. |
DDEvaluator.java |
Handles rejected flags and SemVer evaluation. |
DDEvaluatorTest.java |
Adds refresh-state and canonical parser coverage. |
ConditionOperator.java |
Adds SemVer operators. |
FlagMap.java |
Stores rejected flag keys. |
FlagValidator.java |
Validates UFC flag structures and operands. |
SemanticVersion.java |
Implements SemVer parsing and ordering. |
SemanticVersionTest.java |
Tests SemVer precedence and limits. |
UniversalFlagConfigParser.java |
Independently parses and rejects malformed flags. |
RemoteConfigServiceImplTest.java |
Verifies malformed keys are retained as rejected. |
ffe-system-test-data |
Updates canonical fixture revision. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+138
to
+139
| case INTEGER: | ||
| return value instanceof Number && ((Number) value).doubleValue() % 1 == 0; |
This comment has been minimized.
This comment has been minimized.
Contributor
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
A malformed flag in UFC ingestion must not prevent valid siblings from being evaluated, and rejected keys must produce a parse error instead of looking absent.
Changes
ffe-system-test-datatoea8b5cc5ce335109f11f3efbc5fd608f98a3ca54ERROR/PARSE_ERRORfor malformed flagsFLAG_NOT_FOUNDfor absent keysDecisions
Validation
DDEvaluatorTest: 311/311 passedRemoteConfigServiceImplTest: 31/31 passedSemanticVersionTest: 3/3 passedgit diff --check