Tag evals with the tracer version and ml app - #12184
Draft
ddog-thibault-nadin wants to merge 1 commit into
Draft
Conversation
This comment has been minimized.
This comment has been minimized.
Contributor
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds the
ddtrace.versionandml_apptags to every submitted evaluation metric, so an eval can be filtered by tag and not only through the top levelml_apppayload field.Motivation
Spotted while reviewing #12129: feedback events carry those two tags but evals never did, making the Java tracer the odd one out.
buildMetricTags(tags, mlApp, kind)(packages/dd-trace/src/llmobs/eval-metric.js), which always prefixesddtrace.versionandml_app.evaluation_tagsandfeedback_tagsfrom{"ddtrace.version": __version__, "ml_app": ml_app}(ddtrace/llmobs/_eval_metric.py).Stacked on top of #12129, whose shared
IntakeTags.flattenhelper this reuses. Review that one first.Wire change
Purely additive, but note the
tagsfield is now always present in the eval payload — it used to be omitted entirely when the caller passed no tags.{ "event_kind": "evaluation", "ml_app": "my-app", - "tags": ["source:web-ui"] + "tags": ["ddtrace.version:1.2.3", "ml_app:my-app", "source:web-ui"] }Testing
LLMObsEvalTest, which pins the payload key set, is updated to cover both cases: user supplied tags, and none.