Skip to content

Clean up AI generated code#11606

Open
PerfectSlayer wants to merge 14 commits into
masterfrom
bbujon/groovy-to-java
Open

Clean up AI generated code#11606
PerfectSlayer wants to merge 14 commits into
masterfrom
bbujon/groovy-to-java

Conversation

@PerfectSlayer

@PerfectSlayer PerfectSlayer commented Jun 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

What Does This Do

Clean up AI generated code including:

  • Fix magic constant
  • Fix context API using
  • Remove comment with arg names - always injected by editor and will be out of sync on refactoring
  • Reuse constants from implementations

Introduce new generic TypeConvertor for class constants - will port more existing converters to - that supports both class name qualified constant and constant name only.

Motivation

Additional Notes

Contributor Checklist

  • Format the title according to the contribution guidelines
  • Assign the type: and (comp: or inst:) labels in addition to any other useful labels
  • Avoid using close, fix, or any linking keywords when referencing an issue
    Use solves instead, and assign the PR milestone to the issue
  • Update the CODEOWNERS file on source file addition, migration, or deletion
  • Update public documentation with any new configuration flags or behaviors
  • Add your completed PR to the merge queue by commenting /merge. You can also:
    • Customize the commit message associated with the merge with /merge --commit-message "..."
    • Remove your PR from the merge queue with /merge -c
    • Skip all merge queue checks with /merge -f --reason "reason"; please use this judiciously, as some checks do not run at the PR-level (note: the PR still needs to be mergeable, this will only skip the pre-merge build)
    • Get more information in this doc

Jira ticket: [PROJ-IDENT]

@PerfectSlayer PerfectSlayer added comp: core Tracer core tag: no release notes Changes to exclude from release notes type: refactoring labels Jun 9, 2026
@datadog-official

This comment has been minimized.

Sign in to view
@dd-octo-sts

dd-octo-sts Bot commented Jun 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite Status
Startup 🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
Scenario Candidate master Δ (95% CI of mean)
startup:insecure-bank:iast:Agent 13.91 s 13.97 s [-1.5%; +0.6%] (no difference)
startup:insecure-bank:tracing:Agent 12.93 s 13.02 s [-1.9%; +0.5%] (no difference)
startup:petclinic:appsec:Agent 16.88 s 16.68 s [-0.3%; +2.8%] (no difference)
startup:petclinic:iast:Agent 16.87 s 16.84 s [-1.1%; +1.6%] (no difference)
startup:petclinic:profiling:Agent 16.73 s 16.89 s [-2.7%; +0.7%] (no difference)
startup:petclinic:sca:Agent 16.84 s 16.73 s [-1.0%; +2.4%] (no difference)
startup:petclinic:tracing:Agent 15.08 s 16.02 s [-13.9%; +2.2%] (unstable)

Commit: bdd7b2ce · CI Pipeline · Benchmarking Platform UI

Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

@PerfectSlayer PerfectSlayer marked this pull request as ready for review June 9, 2026 15:38
@PerfectSlayer PerfectSlayer requested review from a team as code owners June 9, 2026 15:38
@PerfectSlayer PerfectSlayer requested review from manuel-alvarez-alvarez and mtoffl01 and removed request for a team June 9, 2026 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bric3 bric3 bric3 approved these changes

@mtoffl01 mtoffl01 Awaiting requested review from mtoffl01 mtoffl01 is a code owner automatically assigned from DataDog/apm-sdk-capabilities-java

@manuel-alvarez-alvarez manuel-alvarez-alvarez Awaiting requested review from manuel-alvarez-alvarez manuel-alvarez-alvarez is a code owner automatically assigned from DataDog/apm-java

Assignees

No one assigned

Labels

comp: core Tracer core tag: no release notes Changes to exclude from release notes type: refactoring

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@PerfectSlayer @bric3