Update EventBridge DSM topic naming#11603
Conversation
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 88fb9c6f00
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -0,0 +1,36 @@ | |||
| package datadog.trace.instrumentation.aws.v2.eventbridge; | |||
|
|
|||
| import static org.junit.jupiter.api.Assertions.assertEquals; | |||
There was a problem hiding this comment.
Add JUnit API to the test compile classpath
This module only adds Spock/Groovy to testImplementation and puts the JUnit 5 bundle on testRuntimeOnly in the shared Gradle setup, so this new Java test has no compile-time dependency for org.junit.jupiter.api.*. In this module, compileTestJava will fail as soon as it tries to compile this file unless the module adds a JUnit Jupiter API/implementation dependency or the test is written using the existing compile-time test dependencies.
Useful? React with 👍 / 👎.
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
What Does This Do
Update the naming convention for Amazon EventBridge DSM context injection as part of a standardisation across all tracers.
Motivation
Similar PR's have been raised across all tracers to standardise how the naming convention works for DSM EventBridge support. The layout was discussed between DSM eng team, PSA team and advocacy.
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issue/merge. You can also:/merge --commit-message "..."/merge -c/merge -f --reason "reason"; please use this judiciously, as some checks do not run at the PR-level (note: the PR still needs to be mergeable, this will only skip the pre-merge build)Jira ticket: [PROJ-IDENT]