feat(spring): Spring Boot 4 — spring-rabbit-1.5 latestDepTest + Boot 4 trie fix#11600
feat(spring): Spring Boot 4 — spring-rabbit-1.5 latestDepTest + Boot 4 trie fix#11600wconti27 wants to merge 3 commits into
Conversation
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
|
PR Blocked - Invalid Label The pull request introduced unexpected labels:
This PR is blocked until:
Note: Simply removing labels from the pull request is not enough - a maintainer must delete this comment then remove the label to remove the block. |
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 420134bb10
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| } | ||
| } | ||
|
|
||
| testJvmConstraints { |
There was a problem hiding this comment.
Move testJvmConstraints after applying the Java plugin
The testJvmConstraints extension is registered by the dd-trace-java.test-jvm-constraints plugin applied from gradle/java.gradle/java_no_deps.gradle, but this block runs before this script applies java.gradle below. When Gradle evaluates this instrumentation project, the testJvmConstraints { ... } call is an unknown method and configuration fails before latestDepTest can run; move the block after the apply from line or configure the latestDepTest task after the suite is created.
Useful? React with 👍 / 👎.
|
Please stop creating label, re-use the existing one instead. |
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
Summary
Two changes that are strictly required together for Spring Boot 4 latestDepTest support in spring-rabbit-1.5:
1. Muzzle + latestDepTest version bump
muzzle.versions:[1.5.0.RELEASE,3)→[1.5.0.RELEASE,5)to cover Spring AMQP 3.x + 4.xlatestDepTestImplementation spring-boot-starter-amqp:2.+→4.+testJvmConstraints { minJavaVersion = JavaVersion.VERSION_17 }(Boot 4 requires Java 17)2. ByteBuddy ignore trie: Boot 4 class relocation
Spring Boot 4 relocates
BackgroundPreinitializertoorg.springframework.boot.autoconfigure.preinitialize.BackgroundPreinitializingApplicationListener. The existing trie entry only covered the old class name. Without this fix, the latestDepTestexecutionErrortest fails because the class is transformed (loaded intoTRANSFORMED_CLASSES_TYPES) but also hits the additional-ignore check.Added:
Verification
./gradlew :dd-java-agent:instrumentation:spring:spring-rabbit-1.5:latestDepTest -PtestJvm=17— BUILD SUCCESSFUL with Spring Boot 4.0.0-RC2.Part of: #11597
🤖 Generated with Claude Code