Migrate utils module Groovy tests to Java tests#11569
Conversation
| } | ||
|
|
||
| @ParameterizedTest | ||
| @MethodSource("convertIterableMapAndBitSetArguments") |
There was a problem hiding this comment.
wasn't sure how to convert this to a TableTest in a simple manner since the method takes multiple types... let me know if you have recommendations!
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
| StableConfigSource stableConfigSource = | ||
| new StableConfigSource(filePath.toString(), ConfigOrigin.LOCAL_STABLE_CONFIG); | ||
|
|
||
| // Create ConfigProvider via reflection (constructor is private) |
There was a problem hiding this comment.
the alternative was having this test file a stableconfig subfolder so that package-private safeToString() can be accessed 🤔
| // spotless:on | ||
|
|
||
| @ParameterizedTest | ||
| @MethodSource("containerInfoParsedFromFileContentArguments") |
There was a problem hiding this comment.
This MethodSource was kept for readability -- TableTest requires inputs to be on one line
What Does This Do
Migrate Groovy tests in the
utilsmodule to Java without changing any functionalityIntroduce TableTest converter for boxed values
Motivation
This is part of a broader initiative to migrate all testing in this repo to JUnit
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issue/merge. You can also:/merge --commit-message "..."/merge -c/merge -f --reason "reason"; please use this judiciously, as some checks do not run at the PR-level (note: the PR still needs to be mergeable, this will only skip the pre-merge build)Jira ticket: [PROJ-IDENT]