feat(jms): toolkit-generated JMS 1.1 + Jakarta JMS 3.0 instrumentation [DO NOT MERGE]#11563
Draft
jordan-wong wants to merge 4 commits into
Draft
feat(jms): toolkit-generated JMS 1.1 + Jakarta JMS 3.0 instrumentation [DO NOT MERGE]#11563jordan-wong wants to merge 4 commits into
jordan-wong wants to merge 4 commits into
Conversation
…n [DO NOT MERGE] Blind test v2 — generated by APM Instrumentation Toolkit new_integration workflow from master 04a3a80 (includes amarziali's #11413 JMS 1.0 work). Generated: javax-jms-1.1/ + jakarta-jms-3.0/ Reviewer: approved (todos_fixed=1, todos_remaining=0) Real cost: ~$63.51 Test iterations: 3 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Generated with APM Instrumentation Toolkit
Summary
04a3a80382, includes amarziali's Have a fully JMS 1.0 compatible instrumentation #11413 JMS 1.0 work)javax-jms-1.1/andjakarta-jms-3.0/modules: producer/consumer/session instrumentation, distributed tracing via message properties, MDB supportJMS1Test.java(1209 lines) +JMS3Test.java(842 lines); reviewer approved in 3 iterationsGeneration details
new_integration(v2)7775ad3e04a3a80382Test plan
:check(compile + spotless + codeNarc + unit tests):muzzleAssertPass for both javax and jakarta modules:instrumentationLatestDepTestfor both modules:forkedTeston JMS dependentsNotes for reviewers
Supersedes #11170 (original JMS 1.1 draft). This run was based on master after amarziali's JMS 1.0 instrumentation (#11413) landed, so the agent had that as a reference. Both javax and jakarta modules generated end-to-end from scratch (blind test).
🤖 Generated with APM Instrumentation Toolkit