Add force jmethodID experimental feature support#11549
Draft
zhengyu123 wants to merge 5 commits into
Draft
Conversation
…dd-trace-java into zgu/experimental_reduce_jmethod
This comment has been minimized.
This comment has been minimized.
Contributor
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
This PR adds an experimental flag
profiling.experimental.ddprof.force_jmethodIDto enable ddprof feature that aims to reduce pre-loading jmethodIDs for all classes.The flag is off (true) by default to preserve current behavior.
Motivation
Preloading all jmethodIDs is proved to be a memory footprint issue. In an extreme case, it consumed 9GB native memory.
ddprof is experimenting a way to lessen dependency on jmethod IDs: none lambda and hidden classes that are loaded by system class loaders (bootstrap, platform and application class loaders), never unloaded. Instead of storing jmethod IDs for the methods of the classes, ddprof stores raw method pointers and resolves at dumping time. Therefore, ddprof does not preload jmethod IDs of none-lambda/hidden classes from those class loaders.
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issue/merge. You can also:/merge --commit-message "..."/merge -c/merge -f --reason "reason"; please use this judiciously, as some checks do not run at the PR-levelJira ticket: [PROJ-IDENT]