Skip to content

Commit 20a0148

Browse files
dougqhclaude
andcommitted
Put span types first in the Java overlay
Span types are what instrumentation developers work with most, so they lead the file, ahead of the routing-only keys and the intercepted list. The header now describes both halves of the file. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
1 parent 16bcf0b commit 20a0148

1 file changed

Lines changed: 22 additions & 22 deletions

File tree

‎tag-conventions-java.yaml‎

Lines changed: 22 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -1,37 +1,22 @@
1-
# Tracer overlay for tag-conventions.yaml — dd-trace-java's set-path routing.
1+
# Tracer overlay for tag-conventions.yaml — dd-trace-java's own span types and set-path routing.
22
# ---------------------------------------------------------------------------
3-
# tag-conventions.yaml is language-agnostic; which keys a tracer intercepts on the set-path (routing
4-
# them to a span field or a sampling directive instead of tag storage) is this tracer's concern, so
5-
# it lives here.
3+
# tag-conventions.yaml is language-agnostic. What only this tracer has lives here: span types for Java
4+
# technologies, and which keys it intercepts on the set-path (routing them to a span field or a
5+
# sampling directive instead of tag storage).
66
#
7+
# span_types — span types only this tracer has, each extending a shared one with tags only this
8+
# tracer sets (servlet's request extends http.server). Their tags get slots like any other.
9+
# mixins — this tracer's cross-cutting tags, pushed onto span types with `applies`. (None yet.)
710
# tags — keys that exist only to be routed, so the conventions do not declare them. They get
811
# ids like any other tag (instrumentation can set them by id) but belong to no span type.
912
# Each is intercepted, so it is not listed again below. Same declaration syntax as
1013
# tag-conventions.yaml; refs are not allowed.
11-
# span_types — span types only this tracer has, each extending a shared one with tags only this
12-
# tracer sets (servlet's request extends http.server). Their tags get slots like any other.
13-
# mixins — this tracer's cross-cutting tags, pushed onto span types with `applies`. (None yet.)
1414
# intercepted — tags declared in tag-conventions.yaml that TagInterceptor also routes. Each one's id carries
1515
# the INTERCEPTED bit, so a setter called with a constant id folds the interception test
1616
# away. TagInterceptor's switch is the authority on what each one does; a test there
1717
# keeps this list and the switch in agreement.
1818
# ---------------------------------------------------------------------------
1919

20-
tags:
21-
- { dd-name: resource.name, type: string }
22-
- { dd-name: span.type, type: string }
23-
- { dd-name: error, type: boolean }
24-
- { dd-name: manual.keep, type: boolean }
25-
- { dd-name: manual.drop, type: boolean }
26-
- { dd-name: asm.keep, type: boolean }
27-
- { dd-name: ai_guard.keep, type: boolean }
28-
- { dd-name: sampling.priority, type: int }
29-
- { dd-name: _dd.p.ts, type: int }
30-
- { dd-name: _dd.p.debug, type: string }
31-
- { dd-name: _dd.origin, type: string }
32-
- { dd-name: _dd.measured, type: boolean }
33-
- { dd-name: _dd1.sr.eausr, type: double }
34-
3520
span_types:
3621
# Servlet requests: http.server spans from a Servlet container, with its context and path.
3722
servlet.request:
@@ -153,6 +138,21 @@ span_types:
153138
- { dd-name: hystrix.group, type: string, required: optional }
154139
- { dd-name: hystrix.circuit-open, type: boolean, required: optional }
155140

141+
tags:
142+
- { dd-name: resource.name, type: string }
143+
- { dd-name: span.type, type: string }
144+
- { dd-name: error, type: boolean }
145+
- { dd-name: manual.keep, type: boolean }
146+
- { dd-name: manual.drop, type: boolean }
147+
- { dd-name: asm.keep, type: boolean }
148+
- { dd-name: ai_guard.keep, type: boolean }
149+
- { dd-name: sampling.priority, type: int }
150+
- { dd-name: _dd.p.ts, type: int }
151+
- { dd-name: _dd.p.debug, type: string }
152+
- { dd-name: _dd.origin, type: string }
153+
- { dd-name: _dd.measured, type: boolean }
154+
- { dd-name: _dd1.sr.eausr, type: double }
155+
156156
intercepted:
157157
- service
158158
- peer.service

0 commit comments

Comments
 (0)