Export plans according to gettext. #98

Jose Lloret · Jose Lloret · commit 6eedf2e7fde2 · 2017-03-15T11:30:08.000Z
diff --git a/app/controllers/plans_controller.rb b/app/controllers/plans_controller.rb
@@ -1,5 +1,6 @@
 class PlansController < ApplicationController
   require 'pp'
+  helper SettingsTemplateHelper
   #Uncomment the line below in order to add authentication to this page - users without permission will not be able to add new plans
   #load_and_authorize_resource
   #
diff --git a/app/helpers/settings_template_helper.rb b/app/helpers/settings_template_helper.rb
@@ -0,0 +1,27 @@
+module SettingsTemplateHelper
+    # Retrieves an msgstr for a given admin_field
+    def admin_field_t(admin_field)
+        if Settings::Template::VALID_ADMIN_FIELDS.include?(admin_field)
+            if admin_field == 'project_name'
+                return _('Plan Name')
+            elsif admin_field == 'project_identifier'
+                return _('Plan ID')
+            elsif admin_field == 'grant_title'
+                return _('Grant number')
+            elsif admin_field == 'principal_investigator'
+                return _('Principal Investigator / Researcher')
+            elsif admin_field == 'project_data_contact'
+                return _('Plan Data Contact')
+            elsif admin_field == 'project_description'
+                return _('Plan Description')
+            elsif admin_field == 'funder'
+                return _('Funder')
+            elsif admin_field == 'institution'
+                return _('Institution')
+            elsif admin_field == 'orcid'
+                return _('Your ORCID')
+            end
+        end
+        return _('Unknown column name.')
+    end
+end
diff --git a/app/views/plans/export.html.erb b/app/views/plans/export.html.erb
@@ -22,14 +22,14 @@
 							if value.present?
 					%>
 						<tr>
-							<th class="dmp_th_border"><p>- <%= t("helpers.plan.export.#{field}") -%></p></th>
+							<th class="dmp_th_border"><p>- <%= admin_field_t(field) -%></p></th>
 							<td class="dmp_td_border"><%= value -%></td>
 						</tr>
 							<% end %>
 						<% end %>
 					</tbody>
 				</table>
-      <% end %>
+      		 <% end %>
 			<% @exported_plan.sections.each do |section| %>
 				<h3><%= section.title %></h3>
 				<table class="dmp_table">
@@ -49,7 +49,7 @@
 	        					<td class="dmp_td_border" >	
 									<% answer = @plan.answer(question.id, false) %>
 									<% if answer.nil? then %>
-										<p>Question not answered.</p>
+										<p><%= _('Question not answered') %></p>
 									<% else %>
                                         <% q_format = question.question_format %>
 										<% if q_format.title == _('Check box') || q_format.title == _('Multi select box') ||
diff --git a/app/views/plans/export.pdf.erb b/app/views/plans/export.pdf.erb
@@ -27,7 +27,7 @@
              value = @exported_plan.send(field)
              if value.present?
         %>
-          <p><strong><%= t("helpers.plan.export.#{field}") -%></strong> <%= value -%></p>
+          <p><strong><%= admin_field_t(field) -%></strong> <%= value -%></p>
           <% end %>
         <% end %>
 
diff --git a/app/views/plans/export.xml.builder b/app/views/plans/export.xml.builder
@@ -8,7 +8,7 @@ xml.plan("id" => @plan.id) do
 		xml.details do
 			details.each do |field|
 				value = @exported_plan.send(field)
-				xml.detail(value, title: t("helpers.plan.export.#{field}")) if value.present?
+				xml.detail(value, title: admin_field_t(field)) if value.present?
 			end
 		end
 	end

Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,6 @@`
`1`	`1`	`class PlansController < ApplicationController`
`2`	`2`	`require 'pp'`
	`3`	`+ helper SettingsTemplateHelper`
`3`	`4`	`#Uncomment the line below in order to add authentication to this page - users without permission will not be able to add new plans`
`4`	`5`	`#load_and_authorize_resource`
`5`	`6`	`#`