fix walls being treated as potential suitable access if another wall is built beneath them

chdoc · chdoc · commit 79f7e5a9baf3 · 2025-04-19T18:25:14.000+02:00
diff --git a/docs/changelog.txt b/docs/changelog.txt
@@ -63,6 +63,7 @@ Template for new versions:
 - `gui/teleport`: now properly handles teleporting units that are currently falling or being flung
 - `unload`: fix recent regression where `unload` would immediately `reload` the target
 - ``Buildings`` module: do not crash if a ``map_block`` unexpectedly contains an item that is not on the master item vector
+- `suspendmanager`: fix walls being treated as potential suitable access if another wall is built underneath
 
 ## Misc Improvements
 - `spectate`: show dwarves' activities (like prayer)
diff --git a/plugins/suspendmanager.cpp b/plugins/suspendmanager.cpp
@@ -387,7 +387,12 @@ class SuspendManager {
         if (isSuitableAccess(pos))
             return true;
 
-        // if a wall is being constructed below, the tile will be suitable
+        // wall-type tiles can never become suitable
+        auto tile_type = Maps::getTileType(pos);
+        if (!tile_type || isWallTerrain(*tile_type))
+            return false;
+
+        // other tiles can become suitable if a wall is being constructed below
         auto below = Buildings::findAtTile(coord(pos.x,pos.y,pos.z-1));
         if (below && below->getType() == df::building_type::Construction &&
             below->getSubtype() == construction_type::Wall)
