Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: miguelgrinberg/python-socketio
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: Cromfel/python-socketio
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: main
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 1 commit
  • 1 file changed
  • 1 contributor

Commits on Jul 27, 2022

  1. Update msgpack_packet.py 

    Using together with non-python implementations causes issues as the payload is optional.

Currently:
`self.data = decoded['data']`

Should be:
`self.data = decoded.get('data')`

Reference:
https://github.com/miguelgrinberg/python-socketio/blob/d556a0ec4de5ef2ca21626ce8b41d68126ec3605/src/socketio/msgpack_packet.py#L16

Documentation: 
https://github.com/socketio/socket.io-protocol#packet-format
    @Cromfel
    Cromfel authored Jul 27, 2022
    Configuration menu
    Copy the full SHA
    e0b3ce1 View commit details
    Browse the repository at this point in the history
Loading