[BUG] [v0.0.7] matches_pattern() silently ignores patterns with multiple wildcards in HookDispatcher #192

Description

The matches_pattern() function in cortex-plugins/src/hooks/dispatcher.rs silently fails to match any tools when the pattern contains multiple wildcards.

Location

File: cortex-plugins/src/hooks/dispatcher.rs
Function: matches_pattern() at line 123

Bug Analysis

The function splits the pattern by * and only handles the case where there are exactly 2 parts:

fn matches_pattern(tool: &str, pattern: &str) -> bool {
    if pattern == "*" {
        return true;
    }

    if pattern.contains('*') {
        // Simple glob matching
        let parts: Vec<&str> = pattern.split('*').collect();
        if parts.len() == 2 {
            let prefix = parts[0];
            let suffix = parts[1];
            return tool.starts_with(prefix) && tool.ends_with(suffix);
        }
    }

    tool == pattern
}

Problem

When a pattern contains multiple wildcards (e.g., read*file*, *read*write*):

1. split('*') produces more than 2 parts
2. The condition parts.len() == 2 is false
3. The function falls through to tool == pattern
4. Since tool never contains *, this always returns false
5. Result: The pattern silently matches nothing

Example

• Pattern read*file* splits into ["read", "file", ""] (3 parts)
• Expected: Match tools like read_file_async, read_file_sync
• Actual: Matches nothing silently

Impact

• Plugin hooks with multi-wildcard patterns will never trigger
• No error or warning is logged
• Users may not realize their hook patterns are not working

Suggested Fix

Either:

1. Support multiple wildcards properly with a proper glob implementation
2. Log a warning when a pattern with multiple wildcards is detected
3. Return an error during pattern registration if multiple wildcards are detected

Version

v0.0.7