Skip to content

Commit 3cebacc

Browse files
committed
Remove assert during deleting models after test cleanup.
- The assert was failing on Windows due to it being unable to delete the model file.
1 parent a49b6cb commit 3cebacc

3 files changed

Lines changed: 13 additions & 2 deletions

File tree

appveyor.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ install:
2121
- cmd: SET PATH=C:\maven\apache-maven-3.3.9\bin;%JAVA_HOME%\bin;%PATH:C:\Ruby193\bin;=%
2222
- cmd: SET MAVEN_OPTS=-XX:MaxPermSize=2g -Xmx4g
2323
- cmd: SET JAVA_OPTS=-XX:MaxPermSize=2g -Xmx4g
24+
- cmd: SET org.ojalgo.OjAlgoUtils.ENVIRONMENT=x86_64
2425
- cmd: mvn --version
2526
- cmd: java -version
2627
build_script:

lbjava/src/test/java/edu/illinois/cs/cogcomp/lbjava/MainTest.java

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -169,6 +169,11 @@ public boolean accept(File dir, String name) {
169169
return !name.endsWith(".lbj") && !name.startsWith(".nfs");
170170
}
171171
});
172-
for (File file: dirFiles) assert file.delete() : "Could not delete file " + file;
172+
173+
for (File file: dirFiles) {
174+
if (!file.delete()) {
175+
System.out.println("Could not delete file " + file);
176+
}
177+
}
173178
}
174179
}

lbjava/src/test/java/edu/illinois/cs/cogcomp/lbjava/NaiveBayesTest.java

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,12 @@ public boolean accept(File dir, String name) {
4646
return !name.endsWith(".lbj");
4747
}
4848
});
49-
for (File file: dirFiles) assert file.delete() : "Could not delete file " + file;
49+
50+
for (File file: dirFiles) {
51+
if (!file.delete()) {
52+
System.out.println("Could not delete file " + file);
53+
}
54+
}
5055
}
5156

5257
@SuppressWarnings({ "unchecked", "rawtypes" })

0 commit comments

Comments
 (0)