Add parsing of MS Access column names with braces (fixes issue27).

andialbrecht · andialbrecht · commit c918cc9dc30b · 2011-07-29T20:58:14.000+02:00
diff --git a/CHANGES b/CHANGES
@@ -16,6 +16,8 @@ Bug Fixes
  * Improve parsing of stand-alone comments (issue26).
  * Detection of placeholders in paramterized queries (issue22,
    reported by Glyph Lefkowitz).
+ * Add parsing of MS Access column names with braces (issue27,
+   reported by frankz...@gmail.com).
 
 
 Release 0.1.2 (Nov 23, 2010)
diff --git a/sqlparse/lexer.py b/sqlparse/lexer.py
@@ -189,6 +189,7 @@ class Lexer:
             (r"(''|'.*?[^\\]')", tokens.String.Single),
             # not a real string literal in ANSI SQL:
             (r'(""|".*?[^\\]")', tokens.String.Symbol),
+            (r'(\[.*[^\]]\])', tokens.Name),
             (r'(LEFT |RIGHT )?(INNER |OUTER )?JOIN\b', tokens.Keyword),
             (r'END( IF| LOOP)?\b', tokens.Keyword),
             (r'NOT NULL\b', tokens.Keyword),
diff --git a/tests/test_parse.py b/tests/test_parse.py
@@ -95,3 +95,10 @@ def _get_tokens(sql):
         self.assert_(t[-1].ttype is sqlparse.tokens.Name.Placeholder)
         self.assertEqual(t[-1].value, '$a')
 
+    def test_access_symbol(self):  # see issue27
+        t = sqlparse.parse('select a.[foo bar] as foo')[0].tokens
+        self.assert_(isinstance(t[-1], sqlparse.sql.Identifier))
+        self.assertEqual(t[-1].get_name(), 'foo')
+        self.assertEqual(t[-1].get_real_name(), '[foo bar]')
+        self.assertEqual(t[-1].get_parent_name(), 'a')
+
