Repository navigation
Expand file tree
/
Copy pathtest_openapi.py
More file actions
404 lines (352 loc) · 15.2 KB
/
Copy pathtest_openapi.py
File metadata and controls
404 lines (352 loc) · 15.2 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
from unittest.mock import MagicMock
import pydantic
import pytest
import openapi_python_client.schema as oai
from openapi_python_client.parser.errors import ParseError
from openapi_python_client.parser.openapi import Endpoint, EndpointCollection, import_string_from_class
from openapi_python_client.parser.properties import Class, IntProperty, Parameters, Schemas
from openapi_python_client.schema import DataType
from openapi_python_client.schema.ref import Ref
from openapi_python_client.schema.untrusted_string import UntrustedString
from openapi_python_client.strings import PythonCode, PythonIdentifier
MODULE_NAME = "openapi_python_client.parser.openapi"
class TestEndpoint:
def make_endpoint(self):
return Endpoint(
path=UntrustedString("path"),
method="method",
description=UntrustedString(""),
name=PythonIdentifier("name", prefix=""),
requires_security=False,
tags=[PythonIdentifier("tag", prefix="")],
relative_imports={"import_3"},
summary=UntrustedString("summary"),
)
def test_add_parameters_handles_no_params(self):
endpoint = self.make_endpoint()
schemas = Schemas()
parameters = Parameters()
config = MagicMock()
# Just checking there's no exception here
assert Endpoint.add_parameters(
endpoint=endpoint,
data=oai.Operation.model_construct(),
schemas=schemas,
parameters=parameters,
config=config,
) == (endpoint, schemas, parameters)
@pytest.mark.parametrize(
"data_type, allowed",
[
(oai.DataType.STRING, True),
(oai.DataType.INTEGER, True),
(oai.DataType.NUMBER, True),
(oai.DataType.BOOLEAN, True),
(oai.DataType.ARRAY, False),
(oai.DataType.OBJECT, False),
],
)
def test_add_parameters_header_types(self, data_type, allowed, config):
endpoint = self.make_endpoint()
initial_schemas = Schemas()
parameters = Parameters()
param = oai.Parameter.model_construct(
name=UntrustedString("test"),
required=True,
param_schema=oai.Schema(type=data_type),
param_in=oai.ParameterLocation.HEADER,
)
result = Endpoint.add_parameters(
endpoint=endpoint,
data=oai.Operation.model_construct(parameters=[param]),
schemas=initial_schemas,
parameters=parameters,
config=config,
)
if allowed:
assert isinstance(result[0], Endpoint)
else:
assert isinstance(result[0], ParseError)
def test__add_parameters_parse_error_on_non_required_path_param(self, config):
endpoint = self.make_endpoint()
param = oai.Parameter.model_construct(
name=UntrustedString("test"),
required=False,
param_schema=oai.Schema.model_construct(type="string"),
param_in=oai.ParameterLocation.PATH,
)
schemas = Schemas()
parameters = Parameters()
result = Endpoint.add_parameters(
endpoint=endpoint,
data=oai.Operation.model_construct(parameters=[param]),
parameters=parameters,
schemas=schemas,
config=config,
)
assert result == (ParseError(data=param, detail="Path parameter must be required"), schemas, parameters)
def test_validation_error_when_location_not_supported(self, mocker):
parsed_schemas = mocker.MagicMock()
mocker.patch(f"{MODULE_NAME}.property_from_data", return_value=(mocker.MagicMock(), parsed_schemas))
with pytest.raises(pydantic.ValidationError):
oai.Parameter(name="test", required=True, param_schema=mocker.MagicMock(), param_in="error_location")
def test__add_parameters_handles_invalid_references(self, config):
"""References are not supported as direct params yet"""
endpoint = self.make_endpoint()
data = oai.Operation.model_construct(
parameters=[
oai.Reference.model_construct(ref=Ref("blah")),
]
)
parameters = Parameters()
(error, _, return_parameters) = endpoint.add_parameters(
endpoint=endpoint, data=data, schemas=Schemas(), parameters=parameters, config=config
)
assert isinstance(error, ParseError)
assert parameters == return_parameters
def test__add_parameters_skips_params_without_schemas(self, config):
"""Params without schemas are allowed per spec, but the any type doesn't make sense as a parameter"""
endpoint = self.make_endpoint()
data = oai.Operation.model_construct(
parameters=[
oai.Parameter.model_construct(
name="param",
param_in="path",
),
]
)
(endpoint, _, _) = endpoint.add_parameters(
endpoint=endpoint, data=data, schemas=Schemas(), parameters=Parameters(), config=config
)
assert isinstance(endpoint, Endpoint)
assert len(endpoint.path_parameters) == 0
def test__add_parameters_same_identifier_conflict(self, config):
endpoint = self.make_endpoint()
data = oai.Operation.model_construct(
parameters=[
oai.Parameter.model_construct(
name=UntrustedString("param"),
param_in="path",
param_schema=oai.Schema.model_construct(type="string"),
required=True,
),
oai.Parameter.model_construct(
name=UntrustedString("param_path"),
param_in="path",
param_schema=oai.Schema.model_construct(type="string"),
required=True,
),
oai.Parameter.model_construct(
name=UntrustedString("param"),
param_in="query",
param_schema=oai.Schema.model_construct(type="string"),
),
]
)
(err, _, _) = endpoint.add_parameters(
endpoint=endpoint, data=data, schemas=Schemas(), parameters=Parameters(), config=config
)
assert isinstance(err, ParseError)
assert "param_path" in err.detail
def test__add_parameters_query_optionality(self, config):
endpoint = self.make_endpoint()
data = oai.Operation.model_construct(
parameters=[
oai.Parameter.model_construct(
name=UntrustedString("not_required"),
required=False,
param_schema=oai.Schema.model_construct(type="string"),
param_in="query",
),
oai.Parameter.model_construct(
name=UntrustedString("required"),
required=True,
param_schema=oai.Schema.model_construct(type="string"),
param_in="query",
),
]
)
(endpoint, _, _) = endpoint.add_parameters(
endpoint=endpoint, data=data, schemas=Schemas(), parameters=Parameters(), config=config
)
assert len(endpoint.query_parameters) == 2, "Not all query params were added"
for param in endpoint.query_parameters:
if param.name == "required":
assert param.required
else:
assert not param.required
def test_add_parameters_duplicate_properties(self, config):
endpoint = self.make_endpoint()
param = oai.Parameter.model_construct(
name=UntrustedString("test"),
required=True,
param_schema=oai.Schema.model_construct(type="string"),
param_in="path",
)
data = oai.Operation.model_construct(parameters=[param, param])
schemas = Schemas()
parameters = Parameters()
result = Endpoint.add_parameters(
endpoint=endpoint, data=data, schemas=schemas, parameters=parameters, config=config
)
assert result == (
ParseError(
data=data,
detail="Parameters MUST NOT contain duplicates. "
"A unique parameter is defined by a combination of a name and location. "
"Duplicated parameters named `test` detected in `path`.",
),
schemas,
parameters,
)
def test_add_parameters_duplicate_properties_different_location(self, config):
endpoint = self.make_endpoint()
path_param = oai.Parameter.model_construct(
name=UntrustedString("test"),
required=True,
param_schema=oai.Schema.model_construct(type="string"),
param_in="path",
)
query_param = oai.Parameter.model_construct(
name=UntrustedString("test"),
required=True,
param_schema=oai.Schema.model_construct(type="string"),
param_in="query",
)
schemas = Schemas()
parameters = Parameters()
result = Endpoint.add_parameters(
endpoint=endpoint,
data=oai.Operation.model_construct(parameters=[path_param, query_param]),
schemas=schemas,
parameters=parameters,
config=config,
)[0]
assert isinstance(result, Endpoint)
assert result.path_parameters[0].name == "test"
assert result.query_parameters[0].name == "test"
def test_sort_parameters(self, string_property_factory):
endpoint = self.make_endpoint()
endpoint.path = UntrustedString("/multiple-path-parameters/{param4}/{param2}/{param1}/{param3}")
for i in range(1, 5):
prop = string_property_factory(name=f"param{i}")
endpoint.path_parameters.append(prop)
result = Endpoint.sort_parameters(endpoint=endpoint)
result_names = [param.name for param in result.path_parameters]
expected_names = [f"param{i}" for i in (4, 2, 1, 3)]
assert result_names == expected_names
def test_sort_parameters_missing_param(self, string_property_factory):
endpoint = self.make_endpoint()
endpoint.path = UntrustedString("/multiple-path-parameters/{param1}/{param2}")
param = string_property_factory(name="param1")
endpoint.path_parameters.append(param)
result = Endpoint.sort_parameters(endpoint=endpoint)
assert isinstance(result, ParseError)
assert "Incorrect path templating" in result.detail
assert endpoint.path.get_untrusted_value() in result.detail
def test_sort_parameters_extra_param(self, string_property_factory):
endpoint = self.make_endpoint()
endpoint.path = UntrustedString("/multiple-path-parameters")
param = string_property_factory(name="param1")
endpoint.path_parameters.append(param)
result = Endpoint.sort_parameters(endpoint=endpoint)
assert isinstance(result, ParseError)
assert "Incorrect path templating" in result.detail
assert endpoint.path.get_untrusted_value() in result.detail
def test_from_data_some_bad_bodies(self, config):
endpoint, _, _ = Endpoint.from_data(
data=oai.Operation(
responses={},
requestBody=oai.RequestBody(
content={
"application/json": oai.MediaType(media_type_schema=oai.Schema(type=DataType.STRING)),
"not a real media type": oai.MediaType(media_type_schema=oai.Schema(type=DataType.STRING)),
},
),
),
schemas=Schemas(),
responses={},
config=config,
parameters=Parameters(),
tags=["tag"],
path=UntrustedString("/"),
method="get",
request_bodies={},
)
assert isinstance(endpoint, Endpoint)
assert len(endpoint.bodies) == 1
assert len(endpoint.errors) == 1
def test_from_data_all_bodies_bad(self, config):
endpoint, _, _ = Endpoint.from_data(
data=oai.Operation(
responses={},
requestBody=oai.RequestBody(
content={
"not a real media type": oai.MediaType(media_type_schema=oai.Schema(type=DataType.STRING)),
},
),
),
schemas=Schemas(),
responses={},
config=config,
parameters=Parameters(),
tags=["tag"],
path=UntrustedString("/"),
method="get",
request_bodies={},
)
assert isinstance(endpoint, ParseError)
@pytest.mark.parametrize(
"response_types, expected",
(([], "Any"), (["Something"], "Something"), (["First", "Second", "Second"], "First | Second")),
)
def test_response_type(self, response_types, expected):
endpoint = self.make_endpoint()
for response_type in response_types:
mock_response = MagicMock()
mock_response.prop.get_type_string.return_value = PythonCode(response_type)
endpoint.responses.patterns.append(mock_response)
assert endpoint.response_type() == PythonCode(expected)
class TestImportStringFromReference:
def test_import_string_from_reference_no_prefix(self, mocker):
class_ = mocker.MagicMock(autospec=Class)
result = import_string_from_class(class_)
assert result == f"from .{class_.module_name} import {class_.name}"
def test_import_string_from_reference_with_prefix(self, mocker):
prefix = mocker.MagicMock(autospec=str)
class_ = mocker.MagicMock(autospec=Class)
result = import_string_from_class(class_=class_, prefix=prefix)
assert result == f"from {prefix}.{class_.module_name} import {class_.name}"
class TestEndpointCollection:
def test_from_data_overrides_path_item_params_with_operation_params(self, config):
data = {
UntrustedString("/"): oai.PathItem.model_construct(
parameters=[
oai.Parameter.model_construct(
name=UntrustedString("param"),
param_in="query",
param_schema=oai.Schema.model_construct(type="string"),
),
],
get=oai.Operation.model_construct(
parameters=[
oai.Parameter.model_construct(
name=UntrustedString("param"),
param_in="query",
param_schema=oai.Schema.model_construct(type="integer"),
)
],
responses={UntrustedString("200"): oai.Response.model_construct(description="blah")},
),
)
}
collections, _schemas, _parameters = EndpointCollection.from_data(
data=data,
schemas=Schemas(),
parameters=Parameters(),
config=config,
request_bodies={},
responses={},
)
collection: EndpointCollection = collections["default"]
assert isinstance(collection.endpoints[0].query_parameters[0], IntProperty)