2.5.2

Konloch · Konloch · commit bf583ec9d9c2 · 2015-01-06T11:12:02.000-08:00
01/06/2015 - Completely fixed the search function with Android APKs.
diff --git a/BytecodeViewer 2.5.2.jar b/BytecodeViewer 2.5.2.jar
diff --git a/README.txt b/README.txt
@@ -235,5 +235,5 @@ Changelog:
 --- 2.5.1 ---:
 01/06/2015 - Silenced the error connecting to update server for offline mode.
 01/06/2015 - Fixed a search function with Android APKs.
---- 2.5.1 ---:
-01/06/2015 - Fixed another issue with LDC searching for Android APKs.01/06/2015 - Fixed another issue with LDC searching for Android APKs.
+--- 2.5.2 ---:
+01/06/2015 - Completely fixed the search function with Android APKs.
diff --git a/src/the/bytecode/club/bytecodeviewer/searching/FieldCallSearch.java b/src/the/bytecode/club/bytecodeviewer/searching/FieldCallSearch.java
@@ -89,6 +89,8 @@ public void search(final ClassNode node, final SearchResultNotifier srn,
 						String desc2 = method.desc;
 						try {
 							desc2 = Type.getType(method.desc).toString();
+							if(desc2 == null || desc2.equals("null"))
+								desc2 = method.desc;
 						} catch(java.lang.ArrayIndexOutOfBoundsException e) {
 							
 						}
@@ -113,6 +115,8 @@ public void search(final ClassNode node, final SearchResultNotifier srn,
 						String desc2 = method.desc;
 						try {
 							desc2 = Type.getType(method.desc).toString();
+							if(desc2 == null || desc2.equals("null"))
+								desc2 = method.desc;
 						} catch(java.lang.ArrayIndexOutOfBoundsException e) {
 							
 						}
diff --git a/src/the/bytecode/club/bytecodeviewer/searching/LDCSearch.java b/src/the/bytecode/club/bytecodeviewer/searching/LDCSearch.java
@@ -63,6 +63,8 @@ public void search(final ClassNode node, final SearchResultNotifier srn,
 					String desc2 = method.desc;
 					try {
 						desc2 = Type.getType(method.desc).toString();
+						if(desc2 == null || desc2.equals("null"))
+							desc2 = method.desc;
 					} catch(java.lang.ArrayIndexOutOfBoundsException e) {
 						
 					}
@@ -80,8 +82,16 @@ public void search(final ClassNode node, final SearchResultNotifier srn,
 		final Iterator<FieldNode> fields = node.fields.iterator();
 		while (methods.hasNext()) {
 			final FieldNode field = fields.next();
+			String desc2 = field.desc;
+			try {
+				desc2 = Type.getType(field.desc).toString();
+				if(desc2 == null || desc2.equals("null"))
+					desc2 = field.desc;
+			} catch(java.lang.ArrayIndexOutOfBoundsException e) {
+				
+			}
 			if (field.value instanceof String) {
-				srn.notifyOfResult(node.name + "." + field.name + field.desc
+				srn.notifyOfResult(node.name + "." + field.name + desc2
 						+ " -> \"" + field.value + "\" > field");
 			}
 		}
diff --git a/src/the/bytecode/club/bytecodeviewer/searching/MethodCallSearch.java b/src/the/bytecode/club/bytecodeviewer/searching/MethodCallSearch.java
@@ -89,6 +89,8 @@ public void search(final ClassNode node, final SearchResultNotifier srn,
 						String desc2 = method.desc;
 						try {
 							desc2 = Type.getType(method.desc).toString();
+							if(desc2 == null || desc2.equals("null"))
+								desc2 = method.desc;
 						} catch(java.lang.ArrayIndexOutOfBoundsException e) {
 							
 						}
@@ -112,6 +114,8 @@ public void search(final ClassNode node, final SearchResultNotifier srn,
 						String desc2 = method.desc;
 						try {
 							desc2 = Type.getType(method.desc).toString();
+							if(desc2 == null || desc2.equals("null"))
+								desc2 = method.desc;
 						} catch(java.lang.ArrayIndexOutOfBoundsException e) {
 							
 						}
diff --git a/src/the/bytecode/club/bytecodeviewer/searching/RegexSearch.java b/src/the/bytecode/club/bytecodeviewer/searching/RegexSearch.java
@@ -58,6 +58,8 @@ public void search(final ClassNode node, final SearchResultNotifier srn,
 				String desc2 = method.desc;
 				try {
 					desc2 = Type.getType(method.desc).toString();
+					if(desc2 == null || desc2.equals("null"))
+						desc2 = method.desc;
 				} catch(java.lang.ArrayIndexOutOfBoundsException e) {
 					
 				}

Original file line number	Diff line number	Diff line change
`@@ -58,6 +58,8 @@ public void search(final ClassNode node, final SearchResultNotifier srn,`
`58`	`58`	`String desc2 = method.desc;`
`59`	`59`	`try {`
`60`	`60`	`desc2 = Type.getType(method.desc).toString();`
	`61`	`+ if(desc2 == null \|\| desc2.equals("null"))`
	`62`	`+ desc2 = method.desc;`
`61`	`63`	`} catch(java.lang.ArrayIndexOutOfBoundsException e) {`
`62`	`64`
`63`	`65`	`}`