bump narwhals version

MarcoGorelli · MarcoGorelli · commit 64b8c700e601 · 2024-10-27T16:01:13.000Z
diff --git a/packages/python/plotly/_plotly_utils/basevalidators.py b/packages/python/plotly/_plotly_utils/basevalidators.py
@@ -201,7 +201,6 @@ def is_homogeneous_array(v):
     """
     np = get_module("numpy", should_load=False)
     pd = get_module("pandas", should_load=False)
-    import narwhals as nw
     if (
         np
         and isinstance(v, np.ndarray)
diff --git a/packages/python/plotly/optional-requirements.txt b/packages/python/plotly/optional-requirements.txt
@@ -39,7 +39,7 @@ ipython
 
 ## pandas deps for some matplotlib functionality ##
 pandas
-narwhals>=1.10.0
+narwhals>=1.11.0
 
 ## scipy deps for some FigureFactory functions ##
 scipy
diff --git a/packages/python/plotly/plotly/express/_core.py b/packages/python/plotly/plotly/express/_core.py
@@ -157,6 +157,9 @@ def invert_label(args, column):
 
 def _is_continuous(df: nw.DataFrame, col_name: str) -> bool:
     if nw.dependencies.is_pandas_like_dataframe(df_native := df.to_native()):
+        # fastpath for pandas: Narwhals' Series.dtype has a bit of overhead, as it
+        # tries to distinguish between true "object" columns, and "string" columns
+        # disguised as "object". But here, we deal with neither.
         return df_native[col_name].dtype.kind in 'ifc'
     return df.get_column(col_name).dtype.is_numeric()
 
@@ -1118,9 +1121,6 @@ def to_unindexed_series(x, name=None, native_namespace=None):
     """
     x = nw.from_native(x, series_only=True, strict=False)
     if isinstance(x, nw.Series):
-        if name == x.name:
-            # Avoid potentially creating a copy in pre-copy-on-write pandas
-            return nw.maybe_reset_index(x)
         return nw.maybe_reset_index(x).rename(name)
     elif native_namespace is not None:
         return nw.new_series(name=name, values=x, native_namespace=native_namespace)
diff --git a/packages/python/plotly/requirements.txt b/packages/python/plotly/requirements.txt
@@ -6,4 +6,4 @@
 ###################################################
 
 ## dataframe agnostic layer ##
-narwhals>=1.10.0
+narwhals>=1.11.0
diff --git a/packages/python/plotly/setup.py b/packages/python/plotly/setup.py
@@ -603,7 +603,7 @@ def run(self):
     data_files=[
         ("etc/jupyter/nbconfig/notebook.d", ["jupyterlab-plotly.json"]),
     ],
-    install_requires=["narwhals>=1.10.0", "packaging"],
+    install_requires=["narwhals>=1.11.0", "packaging"],
     zip_safe=False,
     cmdclass=dict(
         build_py=js_prerelease(versioneer_cmds["build_py"]),
diff --git a/packages/python/plotly/test_requirements/requirements_310_optional.txt b/packages/python/plotly/test_requirements/requirements_310_optional.txt
@@ -21,4 +21,4 @@ kaleido
 orjson==3.8.12
 polars[timezone]
 pyarrow
-narwhals>=1.10.0
+narwhals>=1.11.0
diff --git a/packages/python/plotly/test_requirements/requirements_311_optional.txt b/packages/python/plotly/test_requirements/requirements_311_optional.txt
@@ -21,4 +21,4 @@ kaleido
 orjson==3.8.12
 polars[timezone]
 pyarrow
-narwhals>=1.10.0
+narwhals>=1.11.0
diff --git a/packages/python/plotly/test_requirements/requirements_312_no_numpy_optional.txt b/packages/python/plotly/test_requirements/requirements_312_no_numpy_optional.txt
@@ -20,4 +20,4 @@ kaleido
 orjson==3.9.10
 polars[timezone]
 pyarrow
-narwhals>=1.10.0
+narwhals>=1.11.0
diff --git a/packages/python/plotly/test_requirements/requirements_312_optional.txt b/packages/python/plotly/test_requirements/requirements_312_optional.txt
@@ -21,4 +21,4 @@ kaleido
 orjson==3.9.10
 polars[timezone]
 pyarrow
-narwhals>=1.10.0
+narwhals>=1.11.0
diff --git a/packages/python/plotly/test_requirements/requirements_38_optional.txt b/packages/python/plotly/test_requirements/requirements_38_optional.txt
@@ -21,4 +21,4 @@ psutil==5.7.0
 kaleido
 polars[timezone]
 pyarrow
-narwhals>=1.10.0
+narwhals>=1.11.0
diff --git a/packages/python/plotly/test_requirements/requirements_39_optional.txt b/packages/python/plotly/test_requirements/requirements_39_optional.txt
@@ -22,4 +22,4 @@ kaleido
 orjson==3.8.12
 polars[timezone]
 pyarrow
-narwhals>=1.10.0
+narwhals>=1.11.0
diff --git a/packages/python/plotly/test_requirements/requirements_39_pandas_2_optional.txt b/packages/python/plotly/test_requirements/requirements_39_pandas_2_optional.txt
@@ -22,4 +22,4 @@ vaex
 pydantic<=1.10.11 # for vaex, see https://github.com/vaexio/vaex/issues/2384
 polars[timezone]
 pyarrow
-narwhals>=1.10.0
+narwhals>=1.11.0
