Skip to content

Commit 9895313

Browse files
committed
checkpatch: Remove checks for expedited grace periods
There was a time when the expedited grace-period primitives (synchronize_rcu_expedited(), synchronize_rcu_bh_expedited(), and synchronize_sched_expedited()) used rather antisocial kernel facilities like try_stop_cpus(). However, they have since been housebroken to use only single-CPU IPIs, and typically cause less disturbance than a scheduling-clock interrupt. Furthermore, this disturbance can be eliminated entirely using NO_HZ_FULL on the one hand or the rcupdate.rcu_normal boot parameter on the other. This commit therefore removes checkpatch's complaints about use of the expedited RCU primitives. Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
1 parent dcfc315 commit 9895313

1 file changed

Lines changed: 0 additions & 17 deletions

File tree

scripts/checkpatch.pl

Lines changed: 0 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -5533,23 +5533,6 @@ sub process {
55335533
}
55345534
}
55355535

5536-
# Check for expedited grace periods that interrupt non-idle non-nohz
5537-
# online CPUs. These expedited can therefore degrade real-time response
5538-
# if used carelessly, and should be avoided where not absolutely
5539-
# needed. It is always OK to use synchronize_rcu_expedited() and
5540-
# synchronize_sched_expedited() at boot time (before real-time applications
5541-
# start) and in error situations where real-time response is compromised in
5542-
# any case. Note that synchronize_srcu_expedited() does -not- interrupt
5543-
# other CPUs, so don't warn on uses of synchronize_srcu_expedited().
5544-
# Of course, nothing comes for free, and srcu_read_lock() and
5545-
# srcu_read_unlock() do contain full memory barriers in payment for
5546-
# synchronize_srcu_expedited() non-interruption properties.
5547-
if ($line =~ /\b(synchronize_rcu_expedited|synchronize_sched_expedited)\(/) {
5548-
WARN("EXPEDITED_RCU_GRACE_PERIOD",
5549-
"expedited RCU grace periods should be avoided where they can degrade real-time response\n" . $herecurr);
5550-
5551-
}
5552-
55535536
# check of hardware specific defines
55545537
if ($line =~ m@^.\s*\#\s*if.*\b(__i386__|__powerpc64__|__sun__|__s390x__)\b@ && $realfile !~ m@include/asm-@) {
55555538
CHK("ARCH_DEFINES",

0 commit comments

Comments
 (0)