Skip to content

Commit 53938ee

Browse files
jpoimboeingomolnar
authored andcommitted
scripts/decode_stacktrace.sh: Fix address line detection on x86
Kirill reported that the decode_stacktrace.sh script was broken by the following commit: bb5e5ce ("x86/dumpstack: Remove kernel text addresses from stack dump") Fix it by updating the per-line absolute address check to also check for function-based address lines like the following: write_sysrq_trigger+0x51/0x60 I didn't remove the check for absolute addresses because it's still needed for ARM. Reported-by: Kirill A. Shutemov <kirill@shutemov.name> Tested-by: Kirill A. Shutemov <kirill@shutemov.name> Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com> Cc: Konstantin Khlebnikov <koct9i@gmail.com> Cc: Linus Torvalds <torvalds@linux-foundation.org> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Sasha Levin <alexander.levin@verizon.com> Cc: Thomas Gleixner <tglx@linutronix.de> Fixes: bb5e5ce ("x86/dumpstack: Remove kernel text addresses from stack dump") Link: http://lkml.kernel.org/r/20161128230635.4n2ofgawltgexgcg@treble Signed-off-by: Ingo Molnar <mingo@kernel.org>
1 parent 9b032d2 commit 53938ee

1 file changed

Lines changed: 2 additions & 1 deletion

File tree

scripts/decode_stacktrace.sh

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -139,7 +139,8 @@ handle_line() {
139139

140140
while read line; do
141141
# Let's see if we have an address in the line
142-
if [[ $line =~ \[\<([^]]+)\>\] ]]; then
142+
if [[ $line =~ \[\<([^]]+)\>\] ]] ||
143+
[[ $line =~ [^+\ ]+\+0x[0-9a-f]+/0x[0-9a-f]+ ]]; then
143144
# Translate address to line numbers
144145
handle_line "$line"
145146
# Is it a code line?

0 commit comments

Comments
 (0)