checkpatch: warn on logging continuations

JoePerches · torvalds · commit 45c55e92fcee · 2017-02-24T17:46:57.000-08:00
pr_cont(...) and printk(KERN_CONT ...) uses should be discouraged as their output can be interleaved by multiple logging processes. Link: http://lkml.kernel.org/r/7100ba00098694ec81471a299583ed068975fd05.1483465888.git.joe@perches.com Signed-off-by: Joe Perches <joe@perches.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
@@ -5287,6 +5287,12 @@ sub process {
 			}
 		}
 
+# check for logging continuations
+		if ($line =~ /\bprintk\s*\(\s*KERN_CONT\b|\bpr_cont\s*\(/) {
+			WARN("LOGGING_CONTINUATION",
+			     "Avoid logging continuation uses where feasible\n" . $herecurr);
+		}
+
 # check for mask then right shift without a parentheses
 		if ($^V && $^V ge 5.10.0 &&
 		    $line =~ /$LvalOrFunc\s*\&\s*($LvalOrFunc)\s*>>/ &&

Original file line number	Diff line number	Diff line change
`@@ -5287,6 +5287,12 @@ sub process {`
`5287`	`5287`	`}`
`5288`	`5288`	`}`
`5289`	`5289`
	`5290`	`+# check for logging continuations`
	`5291`	`+ if ($line =~ /\bprintk\s\(\sKERN_CONT\b\|\bpr_cont\s*\(/) {`
	`5292`	`+ WARN("LOGGING_CONTINUATION",`
	`5293`	`+ "Avoid logging continuation uses where feasible\n" . $herecurr);`
	`5294`	`+ }`
	`5295`	`+`
`5290`	`5296`	`# check for mask then right shift without a parentheses`
`5291`	`5297`	`if ($^V && $^V ge 5.10.0 &&`
`5292`	`5298`	`$line =~ /$LvalOrFunc\s\&\s($LvalOrFunc)\s*>>/ &&`