Fixed cppcheck-opensource#5978 (false positive: Array 'm_pool_vector[-1]' accessed at index 0, which is out of bounds.)

danmar · danmar · commit 5ae6234729dd · 2014-07-20T11:44:25.000+02:00
diff --git a/lib/checkbufferoverrun.cpp b/lib/checkbufferoverrun.cpp
@@ -758,8 +758,8 @@ void CheckBufferOverrun::valueFlowCheckArrayIndex(const Token * const tok, const
                 totalElements *= arrayInfo.num(ri);
             }
 
-            // totalElements == 0 => Unknown size
-            if (totalElements == 0)
+            // totalElements <= 0 => Unknown size
+            if (totalElements <= 0)
                 continue;
 
             // taking address of 1 past end?

Original file line number	Diff line number	Diff line change
`@@ -758,8 +758,8 @@ void CheckBufferOverrun::valueFlowCheckArrayIndex(const Token * const tok, const`
`758`	`758`	`totalElements *= arrayInfo.num(ri);`
`759`	`759`	`}`
`760`	`760`
`761`		`- // totalElements == 0 => Unknown size`
`762`		`- if (totalElements == 0)`
	`761`	`+ // totalElements <= 0 => Unknown size`
	`762`	`+ if (totalElements <= 0)`
`763`	`763`	`continue;`
`764`	`764`
`765`	`765`	`// taking address of 1 past end?`