Update PULL_REQUEST_TEMPLATE.md (GoogleCloudPlatform#2676)

lesv · web-flow · commit 88e4176143df · 2020-04-16T21:24:08.000Z
Fixes #&lt;issue_number_goes_here&gt;

&gt; It's a good idea to open an issue first for discussion.

- [x] Tests pass
- [ ] Appropriate changes to README are included in PR
- [ ] API's need to be enabled to test (tell us)
- [ ] Environment Variables need to be set (ask us to set them)
diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md
@@ -2,8 +2,8 @@ Fixes #<issue_number_goes_here>
 
 > It's a good idea to open an issue first for discussion.
 
-- [ ] Tests pass
+- [ ] Tests pass (`mvn -P lint clean verify`)?
+- [ ] `pom.xml` parent set to latest `shared-configuration`
 - [ ] Appropriate changes to README are included in PR
 - [ ] API's need to be enabled to test (tell us)
 - [ ] Environment Variables need to be set (ask us to set them)
-
diff --git a/.kokoro/tests/run_tests.sh b/.kokoro/tests/run_tests.sh
@@ -166,7 +166,7 @@ for file in **/pom.xml; do
     fi
 
     # Use maven to execute the tests for the project.
-    mvn -q --batch-mode --fail-at-end clean verify \
+    mvn -P lint -q --batch-mode --fail-at-end clean verify \
        -Dfile.encoding="UTF-8" \
        -Dorg.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=warn \
        -Dmaven.test.redirectTestOutputToFile=true \
diff --git a/SAMPLE_FORMAT.md b/SAMPLE_FORMAT.md
@@ -284,7 +284,7 @@ tool or IntelliJ plugin.
 To run the Checkstyle, ErrorProne and SpotBugs plugins on an existing sample, run
 
 ```shell
-mvn clean verify -DskipTests
+mvn clean verify -DskipTests -P lint
 ```
 
 The `-DskipTests` is optional. It is useful if you want to verify that your code
