Skip to content

Commit 8327451

Browse files
lesvlesv
authored
Update PR template (GoogleCloudPlatform#3131)
Fixes #issue > It's a good idea to open an issue first for discussion. - [ ] I have followed [Sample Format Guide](https://github.com/GoogleCloudPlatform/java-docs-samples/blob/master/SAMPLE_FORMAT.md) - [ ] `pom.xml` parent set to latest `shared-configuration` - [ ] Appropriate changes to README are included in PR - [ ] API's need to be enabled to test (tell us) - [ ] Environment Variables need to be set (ask us to set them) - [ ] Tests pass (`mvn -P lint clean verify`) * (Note- `Checkstyle` passing is required; `Spotbugs`, `ErrorProne`, `PMD`, etc. `ERROR`'s are advisory only) - [ ] Please **merge** this PR for me once it is approved.
1 parent 0e54843 commit 8327451

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

‎.github/PULL_REQUEST_TEMPLATE.md‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ Fixes #issue
77
- [ ] Appropriate changes to README are included in PR
88
- [ ] API's need to be enabled to test (tell us)
99
- [ ] Environment Variables need to be set (ask us to set them)
10-
- [ ] Tests pass (`mvn -P lint clean verify`)
11-
* (Note- `Checkstyle` passing is required; `Spotbugs`, `ErrorProne`, `PMD`, etc. `ERROR`'s are advisory only)
10+
- [ ] **Tests** pass: `mvn clean verify` **required**
11+
- [ ] **Lint** passes: `mvn -P lint checkstyle:check` **required**
12+
- [ ] **Static Analysis**: `mvn -P lint clean compile pmd:cpd-check spotbugs:check` **advisory only**
1213
- [ ] Please **merge** this PR for me once it is approved.

0 commit comments

Comments
 (0)