Run view port jobs after applying changes

danielgindi · danielgindi · commit 98f97f0df1a9 · 2017-08-25T12:13:45.000+03:00
diff --git a/MPChartLib/src/main/java/com/github/mikephil/charting/charts/Chart.java b/MPChartLib/src/main/java/com/github/mikephil/charting/charts/Chart.java
@@ -1676,20 +1676,23 @@ protected void onSizeChanged(int w, int h, int oldw, int oldh) {
             Log.i(LOG_TAG, "OnSizeChanged()");
 
         if (w > 0 && h > 0 && w < 10000 && h < 10000) {
-
-            mViewPortHandler.setChartDimens(w, h);
-
             if (mLogEnabled)
                 Log.i(LOG_TAG, "Setting chart dimens, width: " + w + ", height: " + h);
+            mViewPortHandler.setChartDimens(w, h);
+        } else {
+            if (mLogEnabled)
+                Log.w(LOG_TAG, "*Avoiding* setting chart dimens! width: " + w + ", height: " + h);
+        }
 
-            for (Runnable r : mJobs) {
-                post(r);
-            }
+        // This may cause the chart view to mutate properties affecting the view port --
+        //   lets do this before we try to run any pending jobs on the view port itself
+        notifyDataSetChanged();
 
-            mJobs.clear();
+        for (Runnable r : mJobs) {
+            post(r);
         }
 
-        notifyDataSetChanged();
+        mJobs.clear();
 
         super.onSizeChanged(w, h, oldw, oldh);
     }
