feat: improve event consumption

rgomezcasas · rgomezcasas · commit b2681585c9b7 · 2023-11-13T19:52:01.000+01:00
diff --git a/etc/http/publish_domain_events.http b/etc/http/publish_domain_events.http
@@ -9,7 +9,7 @@ Content-Type: application/json
       "type": "course.created",
       "occurred_on": "2023-11-14 10:00:00",
       "attributes": {
-        "id": "9bd0c98a-92cc-4a56-a5a1-7d40839ddc83",
+        "id": "c3a11f1d-512e-420b-aeae-e687a3c449aa",
         "name": "Demo course",
         "duration": "2 days"
       }
@@ -31,8 +31,29 @@ Content-Type: application/json
       "type": "course.renamed",
       "occurred_on": "2023-11-14 10:00:00",
       "attributes": {
-        "id": "9bd0c98a-92cc-4a56-a5a1-7d40839ddc83",
-        "name": "heeey 22222"
+        "id": "7b081a3e-f90e-4efe-a3a5-81e853e89c8b",
+        "name": "Este es el nombre bueno"
+      }
+    },
+    "meta": {
+    }
+  }
+}
+
+###
+POST http://localhost:8030/domain-events
+Content-Type: application/json
+
+{
+  "eventName": "course.renamed",
+  "eventRaw": {
+    "data": {
+      "id": "{{$random.uuid}}",
+      "type": "course.renamed",
+      "occurred_on": "2022-11-14 10:00:00",
+      "attributes": {
+        "id": "7b081a3e-f90e-4efe-a3a5-81e853e89c8b",
+        "name": "Este es el nombre malo"
       }
     },
     "meta": {
diff --git a/src/backoffice/main/tv/codely/backoffice/courses/application/create/BackofficeCourseCreator.java b/src/backoffice/main/tv/codely/backoffice/courses/application/create/BackofficeCourseCreator.java
@@ -13,6 +13,8 @@ public BackofficeCourseCreator(BackofficeCourseRepository repository) {
     }
 
     public void create(String id, String name, String duration) {
-        this.repository.save(new BackofficeCourse(id, name, duration));
+		if (this.repository.search(id).isEmpty()) {
+			this.repository.save(new BackofficeCourse(id, name, duration));
+		}
     }
 }
diff --git a/src/backoffice/main/tv/codely/backoffice/courses/infrastructure/persistence/ElasticsearchBackofficeCourseRepository.java b/src/backoffice/main/tv/codely/backoffice/courses/infrastructure/persistence/ElasticsearchBackofficeCourseRepository.java
@@ -14,32 +14,32 @@
 @Primary
 @Service
 public final class ElasticsearchBackofficeCourseRepository extends ElasticsearchRepository<BackofficeCourse> implements BackofficeCourseRepository {
-    public ElasticsearchBackofficeCourseRepository(ElasticsearchClient client) {
-        super(client);
-    }
+	public ElasticsearchBackofficeCourseRepository(ElasticsearchClient client) {
+		super(client);
+	}
 
-    @Override
-    public void save(BackofficeCourse course) {
-        persist(course.id(), course.toPrimitives());
-    }
+	@Override
+	public void save(BackofficeCourse course) {
+		persist(course.id(), course.toPrimitives());
+	}
 
 	@Override
 	public Optional<BackofficeCourse> search(String id) {
 		return this.searchById(id, BackofficeCourse::fromPrimitives);
 	}
 
 	@Override
-    public List<BackofficeCourse> searchAll() {
-        return searchAllInElastic(BackofficeCourse::fromPrimitives);
-    }
-
-    @Override
-    public List<BackofficeCourse> matching(Criteria criteria) {
-        return searchByCriteria(criteria, BackofficeCourse::fromPrimitives);
-    }
-
-    @Override
-    protected String moduleName() {
-        return "courses";
-    }
+	public List<BackofficeCourse> searchAll() {
+		return searchAllInElastic(BackofficeCourse::fromPrimitives);
+	}
+
+	@Override
+	public List<BackofficeCourse> matching(Criteria criteria) {
+		return searchByCriteria(criteria, BackofficeCourse::fromPrimitives);
+	}
+
+	@Override
+	protected String moduleName() {
+		return "courses";
+	}
 }
diff --git a/src/shared/main/tv/codely/shared/infrastructure/bus/event/rabbitmq/RabbitMqDomainEventsConsumer.java b/src/shared/main/tv/codely/shared/infrastructure/bus/event/rabbitmq/RabbitMqDomainEventsConsumer.java
@@ -70,8 +70,12 @@ public void consumer(Message message) throws Exception {
 
         try {
             subscriberOnMethod.invoke(subscriber, domainEvent);
+
+			System.out.println("ACK: Consumed correctly!");
         } catch (Exception error) {
-            handleConsumptionError(message, queue);
+			System.out.println("Error consuming");
+
+			handleConsumptionError(message, queue);
         }
     }
 

Original file line number	Diff line number	Diff line change
`@@ -13,6 +13,8 @@ public BackofficeCourseCreator(BackofficeCourseRepository repository) {`
`13`	`13`	`}`
`14`	`14`
`15`	`15`	`public void create(String id, String name, String duration) {`
`16`		`- this.repository.save(new BackofficeCourse(id, name, duration));`
	`16`	`+ if (this.repository.search(id).isEmpty()) {`
	`17`	`+ this.repository.save(new BackofficeCourse(id, name, duration));`
	`18`	`+ }`
`17`	`19`	`}`
`18`	`20`	`}`
Original file line number	Diff line number	Diff line change
`@@ -70,8 +70,12 @@ public void consumer(Message message) throws Exception {`
`70`	`70`
`71`	`71`	`try {`
`72`	`72`	`subscriberOnMethod.invoke(subscriber, domainEvent);`
	`73`	`+`
	`74`	`+ System.out.println("ACK: Consumed correctly!");`
`73`	`75`	`} catch (Exception error) {`
`74`		`- handleConsumptionError(message, queue);`
	`76`	`+ System.out.println("Error consuming");`
	`77`	`+`
	`78`	`+ handleConsumptionError(message, queue);`
`75`	`79`	`}`
`76`	`80`	`}`
`77`	`81`