Skip to content

Use correct type declaration for amOnPage method#86

Merged
SamMousa merged 2 commits intoCodeception:masterfrom
erickskrauch:fix_amOnPage
May 16, 2023
Merged

Use correct type declaration for amOnPage method#86
SamMousa merged 2 commits intoCodeception:masterfrom
erickskrauch:fix_amOnPage

Conversation

@erickskrauch
Copy link
Copy Markdown
Contributor

This will help me fix my PHPStan integration 🤞

@SamMousa
Copy link
Copy Markdown
Collaborator

I think we added amOnRoute for that, can you check?

Comment thread src/Codeception/Module/Yii2.php Outdated
@erickskrauch erickskrauch requested a review from samdark May 16, 2023 13:37
@SamMousa
Copy link
Copy Markdown
Collaborator

Ah apologies, I shouldn't review PRs on mobile.
LGTM.

@SamMousa SamMousa merged commit 07db4a4 into Codeception:master May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants