Merged
Conversation
Also added dev dependencies for modules used in test cases
The codeception.yml was already adapted to the new paths.
Contributor
Author
|
As written above, I'm not "fluent" in github workflows. As far as I can judge this is because |
Member
|
|
Member
|
https://github.com/yiisoft/yii2-app-advanced/blob/master/composer.json#L39 - this should help. |
Contributor
Author
|
Copying the .gitignore contents first and thinking about it second was not the smartest move 😅 |
samdark
approved these changes
Oct 26, 2021
Arhell
approved these changes
Oct 27, 2021
Member
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I moved the tests from the separate directory to this repository so they can be cloned altogether as discussed here. (Ok, discussion is a strong word, it was talked about in two comments :D )
I can squash the commits if you want (or you do a squash merge), I kept all of them to make retracing my steps easier.
I hope I got the github workflow right, that was my first time working with them. And as always, I would greatly appreciate the
hacktoberfest-acceptedlabel on the PR :)