Added grabCollector function#47
Merged
TavoNiievez merged 1 commit intoCodeception:masterfrom Nov 20, 2020
TavoNiievez:grabCollector
Merged
Added grabCollector function#47TavoNiievez merged 1 commit intoCodeception:masterfrom TavoNiievez:grabCollector
TavoNiievez merged 1 commit intoCodeception:masterfrom
TavoNiievez:grabCollector
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL:DR: I have ready PRs that will make use of this function. It is for internal use only. Some functions are present in the Laravel module and need symfony collectors. This will avoid repeating validation code like in #44.
Clic to see full description
I'm writing at least 4 functions related to form errors that are already available in the Laravel module: - seeFormHasErrors() - dontSeeFormErrors() - seeFormErrorMessages() - seeFormErrorMessage()
And others totally new functions like:
Since all these functions will need their respective collectors of the Symfony Profiler, it is necessary to have a function that validates that it exists and fails the test otherwise,
With
grabCollectori avoid repeating code and having to optimize it later as in #44 .This function is intended only for internal use. with
protectedaccess to be consistent with the other methods of the module.I'll start sending the PRs of the functions I mentioned as soon as this gets merged to master, since the tests will fail before then.