Add ability to use parameters defined in the service container#3
Merged
Naktibalda merged 2 commits intoCodeception:masterfrom Jan 6, 2020
hyprr-social:master
Merged
Add ability to use parameters defined in the service container#3Naktibalda merged 2 commits intoCodeception:masterfrom hyprr-social:master
Naktibalda merged 2 commits intoCodeception:masterfrom
hyprr-social:master
Conversation
…etting a service from the container
Member
|
This small change raises the lowest supported version of PHP to 7.1 |
sergeyklay
suggested changes
Jan 3, 2020
Contributor
sergeyklay
left a comment
There was a problem hiding this comment.
We can't break BC with this small change. At least for a minor module version. Consider to use array $parameter = null instead
Member
|
I think that this change is a feature, so it must be released as 1.1.0, is that right? |
Contributor
|
Yes, I think so |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The parameter $parameters of the method get of the Phalcon's DiInterface can be array or null.
According to this parameter Di container tries to create service. If we have an array of dependencies in our definition, such as
than we can get \Acme\Group without parameters
$group = $container->get('group', null);. In this case we get class Group with injected myComponete.If we use
$group = $container->get('group', []);, than we have got an error " [ArgumentCountError] Too few arguments to function Acme\Group::__construct(), 0 passed and exactly 1 expected ".This pull request adds an ability to use parameters from the container's definition, to create a service.