Skip to content

Fix symfony/dom-crawler 5.3 deprecation#41

Merged
TavoNiievez merged 1 commit intoCodeception:1.xfrom
simonhammes:fix-symfony-dom-crawler-deprecation
Aug 30, 2021
Merged

Fix symfony/dom-crawler 5.3 deprecation#41
TavoNiievez merged 1 commit intoCodeception:1.xfrom
simonhammes:fix-symfony-dom-crawler-deprecation

Conversation

@simonhammes
Copy link
Copy Markdown

@simonhammes simonhammes changed the base branch from master to 1.x August 5, 2021 18:02
@TavoNiievez
Copy link
Copy Markdown
Member

TavoNiievez commented Aug 6, 2021

// The parents() method is deprecated since symfony/dom-crawler v5.3 (https://github.com/symfony/symfony/pull/39684)

I'm not sure about the need to add these comment lines to the source code. If someone wanted to know why those validations were added, they would do a git blame at that point and arrive at this PR, where the link to the Symfony PR should be.

@simonhammes
Copy link
Copy Markdown
Author

// The parents() method is deprecated since symfony/dom-crawler v5.3 (https://github.com/symfony/symfony/pull/39684)

I'm not sure about the need to add these comment lines to the source code. If someone wanted to know why those validations were added, they would do a git blame at that point and arrive at this PR, where the link to the Symfony PR should be.

I can remove the comments if you'd like me to (?)

@TavoNiievez
Copy link
Copy Markdown
Member

@simonhammes Just an opinion, your PR is OK as it is

@kazuwsx
Copy link
Copy Markdown

kazuwsx commented Aug 30, 2021

Hi @TavoNiievez
I'm also encounting this issue(Codeception/Codeception#6239).
When will you merge this PR?

@TavoNiievez TavoNiievez merged commit b33936c into Codeception:1.x Aug 30, 2021
@TavoNiievez
Copy link
Copy Markdown
Member

@kazuwsx right now :) thanks for the reminder.

@simonhammes simonhammes deleted the fix-symfony-dom-crawler-deprecation branch August 30, 2021 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deprecation warning for Symfony DomCrawler\Crawler::parents() when using ->fillField() in PHPBrowser

3 participants