Skip to content

Update code standards [PHP 5.6]#37

Merged
Naktibalda merged 3 commits intoCodeception:masterfrom
TavoNiievez:php56-standards
Apr 18, 2021
Merged

Update code standards [PHP 5.6]#37
Naktibalda merged 3 commits intoCodeception:masterfrom
TavoNiievez:php56-standards

Conversation

@TavoNiievez
Copy link
Copy Markdown
Member

@TavoNiievez TavoNiievez commented Apr 16, 2021

Added type hints and various minor code tweaks.

Comment thread src/Codeception/Lib/InnerBrowser.php Outdated
Comment thread src/Codeception/Lib/InnerBrowser.php Outdated
Comment thread src/Codeception/Lib/InnerBrowser.php Outdated
Comment thread src/Codeception/Lib/InnerBrowser.php Outdated
@TavoNiievez TavoNiievez force-pushed the php56-standards branch 3 times, most recently from d1a6532 to 323f508 Compare April 17, 2021 09:01
@TavoNiievez TavoNiievez marked this pull request as ready for review April 17, 2021 09:04
@TavoNiievez TavoNiievez requested a review from Naktibalda April 17, 2021 09:09
Comment thread src/Codeception/Lib/InnerBrowser.php Outdated
Comment thread src/Codeception/Lib/InnerBrowser.php
@TavoNiievez
Copy link
Copy Markdown
Member Author

@Naktibalda I removed all the dockblocks that I added in public methods that are as an interface implementation and made the regexp change.

@TavoNiievez TavoNiievez requested a review from Naktibalda April 18, 2021 13:50
@Naktibalda Naktibalda merged commit 19d4f74 into Codeception:master Apr 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants