Skip to content

Fix static $defaultName deprecated#6633

Merged
Naktibalda merged 1 commit intoCodeception:5.0from
dmitryuk:completion
Feb 9, 2023
Merged

Fix static $defaultName deprecated#6633
Naktibalda merged 1 commit intoCodeception:5.0from
dmitryuk:completion

Conversation

@dmitryuk
Copy link
Copy Markdown
Contributor

@dmitryuk dmitryuk commented Feb 6, 2023

I don't have stecman/symfony-console-completion package, so Symfony 6.2 throws deprecated error:

PHP Deprecated: Since symfony/console 6.1: Relying on the static property "$defaultName" for setting a command name is deprecated. Add the "Symfony\Component\Console\Attribute\AsCommand" attribute to the "Codeception\Command\CompletionFallback" class instead. in /var/www/vendor/symfony/deprecation-contracts/function.php on line 25

I think we can skip using AsCommand since it have constructor variable for it and supported by all Symfony versions.

@Naktibalda Naktibalda merged commit 27fa4ea into Codeception:5.0 Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants