tryTo methods must always return Boolean result#6614
Merged
Naktibalda merged 1 commit into5.0from Dec 17, 2022
Merged
Conversation
Arhell
approved these changes
Dec 9, 2022
jmrieger
approved these changes
Dec 12, 2022
jmrieger
left a comment
There was a problem hiding this comment.
Running into this same issue when updating to Codeception 5. The proposed changes definitely look like they will solve the attached issue, and I also appreciate including the logical check for this in tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6559