Make dry-run work with module methods having return types#6470
Merged
Naktibalda merged 1 commit into4.2from Jun 16, 2022
Merged
Make dry-run work with module methods having return types#6470Naktibalda merged 1 commit into4.2from
Naktibalda merged 1 commit into4.2from
Conversation
TavoNiievez
approved these changes
Jun 10, 2022
Member
TavoNiievez
left a comment
There was a problem hiding this comment.
ask for my review when you go to integrate to the 5.0 branch, I have a couple of suggestions for typing
Member
Author
|
Now I think that it would be better to mock all methods of all modules to return correct types. The main problem is that methods implemented in Tester classes are not steps, so they won't be mocked and they will call methods of real modules. |
Member
Author
|
I updated code to mock all modules method, so dry-run works as before, but methods return correct types. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6463