drop deprecated setConnectionKeepAlive method, add javadoc

kullfar · kullfar · commit 4f59e5ee49ee · 2016-11-18T17:59:48.000+03:00
diff --git a/changelog b/changelog
@@ -4,6 +4,7 @@
  * add Box (thanks to https://github.com/MclaughlinSteve)
  * fix: OAuth20Service::refreshAccessToken should use RefreshTokenEndpoint, not AccessTokenEndpoint (thanks to https://github.com/vivin)
  * move signRequest method to OAuthService (common for OAuth1 and OAuth2) (thanks to https://github.com/apomelov)
+ * drop deprecated setConnectionKeepAlive method
 
 [3.2.0]
  * Add Naver API (thanks to chooco)
diff --git a/scribejava-core/src/main/java/com/github/scribejava/core/model/AbstractRequest.java b/scribejava-core/src/main/java/com/github/scribejava/core/model/AbstractRequest.java
@@ -254,20 +254,6 @@ public void setCharset(String charsetName) {
         charset = charsetName;
     }
 
-    /**
-     * Sets whether the underlying Http Connection is persistent or not.
-     *
-     * @param connectionKeepAlive boolean
-     *
-     * @see <a
-     * href="http://download.oracle.com/javase/1.5.0/docs/guide/net/http-keepalive.html">http://download.oracle.com/javase/1.5.0/docs/guide/net/http-keepalive.html</a>
-     * @deprecated does nothing - JVM default is left untouched. Set {@code http.keepAlive} system property to
-     * {@code false} for pre-deprecation behavior.
-     */
-    @Deprecated
-    public void setConnectionKeepAlive(boolean connectionKeepAlive) {
-    }
-
     /**
      * Sets whether the underlying Http Connection follows redirects or not.
      *
diff --git a/scribejava-core/src/main/java/com/github/scribejava/core/oauth/OAuthService.java b/scribejava-core/src/main/java/com/github/scribejava/core/oauth/OAuthService.java
@@ -21,6 +21,7 @@
  * The main ScribeJava object.
  *
  * A facade responsible for the retrieval of request and access tokens and for the signing of HTTP requests.
+ * @param <T> type of token used to sign the request
  */
 public abstract class OAuthService<T extends Token> {
 

Original file line number	Diff line number	Diff line change
`@@ -21,6 +21,7 @@`
`21`	`21`	`* The main ScribeJava object.`
`22`	`22`	`*`
`23`	`23`	`* A facade responsible for the retrieval of request and access tokens and for the signing of HTTP requests.`
	`24`	`+ * @param <T> type of token used to sign the request`
`24`	`25`	`*/`
`25`	`26`	`public abstract class OAuthService<T extends Token> {`
`26`	`27`