Fix ToPromise not returning when faulted

dcrusader · web-flow · commit 57974e62ad07 · 2020-05-15T15:56:03.000-07:00
ToPromise was not properly calling `reject` when an exception was encountered.
diff --git a/ClearScript/JavaScript/JavaScriptExtensions.cs b/ClearScript/JavaScript/JavaScriptExtensions.cs
@@ -45,7 +45,7 @@ public static object ToPromise<TResult>(this Task<TResult> task, ScriptEngine en
             {
                 task.ContinueWith(thisTask =>
                 {
-                    if (thisTask.IsCompleted)
+                    if (thisTask.IsCompleted && !thisTask.IsCanceled && !thisTask.IsFaulted)
                     {
                         resolve(thisTask.Result);
                     }
@@ -87,7 +87,7 @@ public static object ToPromise(this Task task, ScriptEngine engine)
             {
                 task.ContinueWith(thisTask =>
                 {
-                    if (thisTask.IsCompleted)
+                    if (thisTask.IsCompleted && !thisTask.IsCanceled && !thisTask.IsFaulted)
                     {
                         resolve();
                     }

Original file line number	Diff line number	Diff line change
`@@ -45,7 +45,7 @@ public static object ToPromise<TResult>(this Task<TResult> task, ScriptEngine en`
`45`	`45`	`{`
`46`	`46`	`task.ContinueWith(thisTask =>`
`47`	`47`	`{`
`48`		`- if (thisTask.IsCompleted)`
	`48`	`+ if (thisTask.IsCompleted && !thisTask.IsCanceled && !thisTask.IsFaulted)`
`49`	`49`	`{`
`50`	`50`	`resolve(thisTask.Result);`
`51`	`51`	`}`
`@@ -87,7 +87,7 @@ public static object ToPromise(this Task task, ScriptEngine engine)`
`87`	`87`	`{`
`88`	`88`	`task.ContinueWith(thisTask =>`
`89`	`89`	`{`
`90`		`- if (thisTask.IsCompleted)`
	`90`	`+ if (thisTask.IsCompleted && !thisTask.IsCanceled && !thisTask.IsFaulted)`
`91`	`91`	`{`
`92`	`92`	`resolve();`
`93`	`93`	`}`