Skip to content

Commit c13f9f2

Browse files
committed
all: Convert nlr_raise(mp_obj_new_exception_msg(x)) to mp_raise_msg(x).
This helper function was added a while ago and these are the remaining cases to convert, to save a bit of code size.
1 parent 80df377 commit c13f9f2

19 files changed

Lines changed: 30 additions & 35 deletions

extmod/moductypes.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -558,7 +558,7 @@ STATIC mp_obj_t uctypes_struct_subscr(mp_obj_t self_in, mp_obj_t index_in, mp_ob
558558
uint val_type = GET_TYPE(arr_sz, VAL_TYPE_BITS);
559559
arr_sz &= VALUE_MASK(VAL_TYPE_BITS);
560560
if (index >= arr_sz) {
561-
nlr_raise(mp_obj_new_exception_msg(&mp_type_IndexError, "struct: index out of range"));
561+
mp_raise_msg(&mp_type_IndexError, "struct: index out of range");
562562
}
563563

564564
if (t->len == 2) {

extmod/moduheapq.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ STATIC MP_DEFINE_CONST_FUN_OBJ_2(mod_uheapq_heappush_obj, mod_uheapq_heappush);
8181
STATIC mp_obj_t mod_uheapq_heappop(mp_obj_t heap_in) {
8282
mp_obj_list_t *heap = uheapq_get_heap(heap_in);
8383
if (heap->len == 0) {
84-
nlr_raise(mp_obj_new_exception_msg(&mp_type_IndexError, "empty heap"));
84+
mp_raise_msg(&mp_type_IndexError, "empty heap");
8585
}
8686
mp_obj_t item = heap->items[0];
8787
heap->len -= 1;

extmod/modutimeq.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -142,7 +142,7 @@ STATIC MP_DEFINE_CONST_FUN_OBJ_VAR_BETWEEN(mod_utimeq_heappush_obj, 4, 4, mod_ut
142142
STATIC mp_obj_t mod_utimeq_heappop(mp_obj_t heap_in, mp_obj_t list_ref) {
143143
mp_obj_utimeq_t *heap = utimeq_get_heap(heap_in);
144144
if (heap->len == 0) {
145-
nlr_raise(mp_obj_new_exception_msg(&mp_type_IndexError, "empty heap"));
145+
mp_raise_msg(&mp_type_IndexError, "empty heap");
146146
}
147147
mp_obj_list_t *ret = MP_OBJ_TO_PTR(list_ref);
148148
if (!mp_obj_is_type(list_ref, &mp_type_list) || ret->len < 3) {
@@ -167,7 +167,7 @@ STATIC MP_DEFINE_CONST_FUN_OBJ_2(mod_utimeq_heappop_obj, mod_utimeq_heappop);
167167
STATIC mp_obj_t mod_utimeq_peektime(mp_obj_t heap_in) {
168168
mp_obj_utimeq_t *heap = utimeq_get_heap(heap_in);
169169
if (heap->len == 0) {
170-
nlr_raise(mp_obj_new_exception_msg(&mp_type_IndexError, "empty heap"));
170+
mp_raise_msg(&mp_type_IndexError, "empty heap");
171171
}
172172

173173
struct qentry *item = &heap->items[0];

extmod/network_cyw43.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -196,7 +196,7 @@ STATIC mp_obj_t network_cyw43_scan(size_t n_args, const mp_obj_t *pos_args, mp_m
196196
int scan_res = cyw43_wifi_scan(self->cyw, &opts, MP_OBJ_TO_PTR(res), network_cyw43_scan_cb);
197197

198198
if (scan_res < 0) {
199-
nlr_raise(mp_obj_new_exception_msg(&mp_type_OSError, "STA must be active"));
199+
mp_raise_msg(&mp_type_OSError, "STA must be active");
200200
}
201201

202202
// Wait for scan to finish, with a 10s timeout

extmod/vfs_posix_file.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ typedef struct _mp_obj_vfs_posix_file_t {
4444
#ifdef MICROPY_CPYTHON_COMPAT
4545
STATIC void check_fd_is_open(const mp_obj_vfs_posix_file_t *o) {
4646
if (o->fd < 0) {
47-
nlr_raise(mp_obj_new_exception_msg(&mp_type_ValueError, "I/O operation on closed file"));
47+
mp_raise_msg(&mp_type_ValueError, "I/O operation on closed file");
4848
}
4949
}
5050
#else

ports/esp32/modesp32.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ STATIC mp_obj_t esp32_wake_on_touch(const mp_obj_t wake) {
4848
if (machine_rtc_config.ext0_pin != -1) {
4949
mp_raise_ValueError("no resources");
5050
}
51-
//nlr_raise(mp_obj_new_exception_msg(&mp_type_RuntimeError, "touchpad wakeup not available for this version of ESP-IDF"));
51+
//mp_raise_msg(&mp_type_RuntimeError, "touchpad wakeup not available for this version of ESP-IDF");
5252

5353
machine_rtc_config.wake_on_touch = mp_obj_is_true(wake);
5454
return mp_const_none;
@@ -74,7 +74,7 @@ STATIC mp_obj_t esp32_wake_on_ext0(size_t n_args, const mp_obj_t *pos_args, mp_m
7474
gpio_num_t pin_id = machine_pin_get_id(args[ARG_pin].u_obj);
7575
if (pin_id != machine_rtc_config.ext0_pin) {
7676
if (!RTC_IS_VALID_EXT_PIN(pin_id)) {
77-
nlr_raise(mp_obj_new_exception_msg(&mp_type_ValueError, "invalid pin"));
77+
mp_raise_msg(&mp_type_ValueError, "invalid pin");
7878
}
7979
machine_rtc_config.ext0_pin = pin_id;
8080
}
@@ -109,7 +109,7 @@ STATIC mp_obj_t esp32_wake_on_ext1(size_t n_args, const mp_obj_t *pos_args, mp_m
109109

110110
gpio_num_t pin_id = machine_pin_get_id(elem[i]);
111111
if (!RTC_IS_VALID_EXT_PIN(pin_id)) {
112-
nlr_raise(mp_obj_new_exception_msg(&mp_type_ValueError, "invalid pin"));
112+
mp_raise_msg(&mp_type_ValueError, "invalid pin");
113113
break;
114114
}
115115
ext1_pins |= (1ll << pin_id);

ports/esp32/modmachine.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,7 @@ STATIC mp_obj_t machine_sleep_helper(wake_type_t wake_type, size_t n_args, const
119119

120120
if (machine_rtc_config.wake_on_touch) {
121121
if (esp_sleep_enable_touchpad_wakeup() != ESP_OK) {
122-
nlr_raise(mp_obj_new_exception_msg(&mp_type_RuntimeError, "esp_sleep_enable_touchpad_wakeup() failed"));
122+
mp_raise_msg(&mp_type_RuntimeError, "esp_sleep_enable_touchpad_wakeup() failed");
123123
}
124124
}
125125

ports/esp32/modnetwork.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -233,7 +233,7 @@ static esp_err_t event_handler(void *ctx, system_event_t *event) {
233233

234234
/*void error_check(bool status, const char *msg) {
235235
if (!status) {
236-
nlr_raise(mp_obj_new_exception_msg(&mp_type_OSError, msg));
236+
mp_raise_msg(&mp_type_OSError, msg);
237237
}
238238
}
239239
*/
@@ -441,7 +441,7 @@ STATIC mp_obj_t esp_scan(mp_obj_t self_in) {
441441
wifi_mode_t mode;
442442
ESP_EXCEPTIONS(esp_wifi_get_mode(&mode));
443443
if ((mode & WIFI_MODE_STA) == 0) {
444-
nlr_raise(mp_obj_new_exception_msg(&mp_type_OSError, "STA must be active"));
444+
mp_raise_msg(&mp_type_OSError, "STA must be active");
445445
}
446446

447447
mp_obj_t list = mp_obj_new_list(0, NULL);

ports/esp32/mpthreadport.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@
2727

2828
#include "stdio.h"
2929

30+
#include "py/runtime.h"
3031
#include "py/gc.h"
3132
#include "py/mpthread.h"
3233
#include "py/mphal.h"
@@ -135,7 +136,7 @@ void mp_thread_create_ex(void *(*entry)(void*), void *arg, size_t *stack_size, i
135136
BaseType_t result = xTaskCreatePinnedToCore(freertos_entry, name, *stack_size / sizeof(StackType_t), arg, priority, &th->id, MP_TASK_COREID);
136137
if (result != pdPASS) {
137138
mp_thread_mutex_unlock(&thread_mutex);
138-
nlr_raise(mp_obj_new_exception_msg(&mp_type_OSError, "can't create thread"));
139+
mp_raise_msg(&mp_type_OSError, "can't create thread");
139140
}
140141

141142
// adjust the stack_size to provide room to recover from hitting the limit

ports/esp8266/esp_mphal.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -149,8 +149,7 @@ void ets_event_poll(void) {
149149

150150
void __assert_func(const char *file, int line, const char *func, const char *expr) {
151151
printf("assert:%s:%d:%s: %s\n", file, line, func, expr);
152-
nlr_raise(mp_obj_new_exception_msg(&mp_type_AssertionError,
153-
"C-level assert"));
152+
mp_raise_msg(&mp_type_AssertionError, "C-level assert");
154153
}
155154

156155
void mp_hal_signal_input(void) {

0 commit comments

Comments
 (0)