Skip to content

Commit a3efe04

Browse files
stinospfalcon
authored andcommitted
Use mode/encoding kwargs in io and unicode tests
mode argument is used to assert it works encoding argument is used to make sure CPython uses the correct encoding as it does not automatically use utf-8
1 parent 2fe4cf7 commit a3efe04

File tree

3 files changed

+14
-2
lines changed

3 files changed

+14
-2
lines changed

tests/io/file1.py

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,3 +4,11 @@
44
print(f.read())
55
f = open("io/data/file1")
66
print(f.readlines())
7+
f = open("io/data/file1","r")
8+
print(f.readlines())
9+
f = open("io/data/file1","rb")
10+
print(f.readlines())
11+
f = open("io/data/file1",mode="r")
12+
print(f.readlines())
13+
f = open("io/data/file1",mode="rb")
14+
print(f.readlines())

tests/unicode/file1.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
f = open("unicode/data/utf-8_1.txt")
1+
f = open("unicode/data/utf-8_1.txt", encoding="utf-8")
22
l = f.readline()
33
print(l)
44
print(len(l))

tests/unicode/file2.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,11 @@
11
# test reading a given number of characters
22

33
def do(mode):
4-
f = open('unicode/data/utf-8_2.txt', mode)
4+
if mode == 'rb':
5+
enc = None
6+
else:
7+
enc = 'utf-8'
8+
f = open('unicode/data/utf-8_2.txt', mode=mode, encoding=enc)
59
print(f.read(1))
610
print(f.read(1))
711
print(f.read(2))

0 commit comments

Comments
 (0)