esp32/mpthreadport: Use binary semaphore instead of mutex.

dpgeorge · dpgeorge · commit 864e4ecc47f2 · 2021-05-08T22:47:03.000+10:00
So a lock can be acquired on one Python thread and then released on
another.  A test for this is added.

Signed-off-by: Damien George &lt;damien@micropython.org&gt;
diff --git a/ports/esp32/mpthreadport.c b/ports/esp32/mpthreadport.c
@@ -192,7 +192,10 @@ void vPortCleanUpTCB(void *tcb) {
 }
 
 void mp_thread_mutex_init(mp_thread_mutex_t *mutex) {
-    mutex->handle = xSemaphoreCreateMutexStatic(&mutex->buffer);
+    // Need a binary semaphore so a lock can be acquired on one Python thread
+    // and then released on another.
+    mutex->handle = xSemaphoreCreateBinaryStatic(&mutex->buffer);
+    xSemaphoreGive(mutex->handle);
 }
 
 int mp_thread_mutex_lock(mp_thread_mutex_t *mutex, int wait) {
diff --git a/tests/thread/thread_lock5.py b/tests/thread/thread_lock5.py
@@ -0,0 +1,16 @@
+# test _thread lock objects where a lock is acquired/released by a different thread
+
+import _thread
+
+
+def thread_entry():
+    print("thread about to release lock")
+    lock.release()
+
+
+lock = _thread.allocate_lock()
+lock.acquire()
+_thread.start_new_thread(thread_entry, ())
+lock.acquire()
+print("main has lock")
+lock.release()

Original file line number	Diff line number	Diff line change
`@@ -192,7 +192,10 @@ void vPortCleanUpTCB(void *tcb) {`
`192`	`192`	`}`
`193`	`193`
`194`	`194`	`void mp_thread_mutex_init(mp_thread_mutex_t *mutex) {`
`195`		`- mutex->handle = xSemaphoreCreateMutexStatic(&mutex->buffer);`
	`195`	`+ // Need a binary semaphore so a lock can be acquired on one Python thread`
	`196`	`+ // and then released on another.`
	`197`	`+ mutex->handle = xSemaphoreCreateBinaryStatic(&mutex->buffer);`
	`198`	`+ xSemaphoreGive(mutex->handle);`
`196`	`199`	`}`
`197`	`200`
`198`	`201`	`int mp_thread_mutex_lock(mp_thread_mutex_t *mutex, int wait) {`