os_listdir: This can be long-running, run background tasks

jepler · jepler · commit 676f7aa80821 · 2019-09-09T20:14:02.000-05:00
While finding sources of clicks and buzzes in nrf i2sout, I identified
this site as one which could be long running.  Reproducer code was to
play a 22.05kHz sample and repeatedly print `os.listdir('')`
diff --git a/shared-module/os/__init__.c b/shared-module/os/__init__.c
@@ -128,6 +128,7 @@ mp_obj_t common_hal_os_listdir(const char* path) {
     while ((next = mp_iternext(iter_obj)) != MP_OBJ_STOP_ITERATION) {
         // next[0] is the filename.
         mp_obj_list_append(dir_list, mp_obj_subscr(next, MP_OBJ_NEW_SMALL_INT(0), MP_OBJ_SENTINEL));
+        RUN_BACKGROUND_TASKS;
     }
     return dir_list;
 }

Original file line number	Diff line number	Diff line change
`@@ -128,6 +128,7 @@ mp_obj_t common_hal_os_listdir(const char* path) {`
`128`	`128`	`while ((next = mp_iternext(iter_obj)) != MP_OBJ_STOP_ITERATION) {`
`129`	`129`	`// next[0] is the filename.`
`130`	`130`	`mp_obj_list_append(dir_list, mp_obj_subscr(next, MP_OBJ_NEW_SMALL_INT(0), MP_OBJ_SENTINEL));`
	`131`	`+ RUN_BACKGROUND_TASKS;`
`131`	`132`	`}`
`132`	`133`	`return dir_list;`
`133`	`134`	`}`