quic: prevent copying ngtcp2_cid

tniessen · Ceres6 · commit 76a2dc423b17 · 2023-08-14T19:35:39.000+02:00
The existing code explicitly uses the CID(const ngtcp2_cid*) constructor that does not copy the given ngtcp2_cid, but the range-based for loop still unnecessarily copies the ngtcp2_cid. Use auto& to avoid copying. PR-URL: nodejs#48561 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
diff --git a/src/quic/session.cc b/src/quic/session.cc
@@ -643,7 +643,7 @@ void Session::Destroy() {
   endpoint_->DisassociateCID(config_.dcid);
   endpoint_->DisassociateCID(config_.preferred_address_cid);
 
-  for (auto cid : cids) endpoint_->DisassociateCID(CID(&cid));
+  for (const auto& cid : cids) endpoint_->DisassociateCID(CID(&cid));
 
   for (const auto& token : tokens) {
     if (token.token_present)
